Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: use latest 14.2.2 code #3489

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@leseb
Copy link
Member

commented Jul 22, 2019

14.2.2 is out and along with it numerous fixes so let's use it.

Signed-off-by: Sébastien Han seb@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[test ceph]

@travisn
Copy link
Member

left a comment

Looks like there is just one more place to update in images/ceph/Makefile

@Madhu-1

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@ajarr @leseb is this images having all the changes required for cephcsi cephfs to work?

@leseb

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@Madhu-1 if they are in 14.2.2 then yes.

ceph: use latest 14.2.2 code
14.2.2 is out and along with it numerous fixes so let's use it.

Signed-off-by: Sébastien Han <seb@redhat.com>

@leseb leseb force-pushed the leseb:switch-to-14.2.2 branch from 2969325 to 41d2953 Jul 22, 2019

@leseb

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@travisn done.

@BlaineEXE

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

It looks like it failed the ARM build. It looks like the ceph ARM image was built 4 days ago (v14.2.2-20190718) whereas the x86_64/amd64 image was built just a few hours ago (v14.2.2-20190722). Was the ARM package really available before the x86_64 one?

@leseb

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@BlaineEXE yes, it looks like the 14.2.2 arm64 was build last week so their timestamp doesn't match, I'm rebuilding arm right now.

@travisn

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

We've had this issue before with the different timestamps, the fix was to use the condition ifeq ($(GOARCH),amd64) to handle the different images for different arch.

@BlaineEXE BlaineEXE added the ceph - label Jul 22, 2019

@travisn

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@Madhu-1 Per discussion with @ajarr all the critical changes needed for csi-cephfs should be in 14.2.2. The fixes coming in 14.2.3 will include improvements, but should not include api changes. The timeline for 14.2.3 is still unknown so let's proceed with the assumption that Rook v1.1 will release based on 14.2.2.

@travisn travisn merged commit 36479fe into rook:master Jul 22, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@leseb leseb deleted the leseb:switch-to-14.2.2 branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.