Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fencing): changes mdb controller to use namespace for checking ceph status #3879

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@ashishranjan738
Copy link
Contributor

ashishranjan738 commented Sep 17, 2019

This commit changed mdb controller to make use of cephCluster's namespace instead of cephCluster's name for checking the ceph health as the ceph config is located in the cephCluster's namespace folder which can makes mdb controller fail when rook operator is deployed in any other namespace apart from rook-ceph.

Signed-off-by: Ashish Ranjan aranjan@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[skip ci] leseb:
remote file operation failed: /home/ubuntu/workspace/rook_rook_PR-3879-VEMWZ3RY63VMCDNM6XBATOZHMQGANT464RZQUBAQPAFKHZFDWHBQ at hudson.remoting.Channel@7b32ff8f:rook-node-ec2 (i-0cb6424dba95b249c): hudson.remoting.ChannelClosedException: Remote call on rook-node-ec2 (i-0cb6424dba95b249c) failed. The channel is closing down or has closed down

This commit changed mdb controller to make use of cephCluster's namespace instead of cephCluster's name for checking the ceph health as the ceph config is located in the cephCluster's namespace folder which can makes mdb controller fail when rook operator is deployed in any other namespace apart from rook-ceph.

Signed-off-by: Ashish Ranjan <aranjan@redhat.com>
@ashishranjan738 ashishranjan738 force-pushed the ashishranjan738:mdbfix branch from 838c6b6 to c4ee336 Sep 17, 2019
@leseb
leseb approved these changes Sep 17, 2019
@leseb leseb merged commit d3104ed into rook:master Sep 17, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@leseb

This comment has been minimized.

Copy link
Member

leseb commented Sep 17, 2019

@ashishranjan738 please send a backport PR. Thanks.

@ashishranjan738

This comment has been minimized.

Copy link
Contributor Author

ashishranjan738 commented Sep 19, 2019

cool will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.