Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceph-volume skip restorecon #4260

Merged
merged 2 commits into from Nov 12, 2019
Merged

Ceph-volume skip restorecon #4260

merged 2 commits into from Nov 12, 2019

Conversation

@leseb
Copy link
Member

leseb commented Nov 5, 2019

Description of your changes:

This reverts commit d224fbd.
Since ceph/ceph#31421, the monkey patching of
'restorecon' is not needed anymore.

This will tell ceph-volume not to run any restorecon commands by using the new environment variable CEPH_VOLUME_SKIP_RESTORECON.
This relies on ceph/ceph#31421

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[test ceph]

@leseb leseb requested a review from travisn Nov 5, 2019
pkg/operator/ceph/cluster/osd/spec.go Show resolved Hide resolved
pkg/operator/ceph/cluster/osd/spec.go Outdated Show resolved Hide resolved
This reverts commit d224fbd.
Since ceph/ceph#31421, the monkey patching of
'restorecon' is not needed anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb force-pushed the leseb:cv-skip-restorecon branch from aa53acb to aa30458 Nov 12, 2019
This will tell ceph-volume not to run any restorecon commands.

This relies on ceph/ceph#31421

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb force-pushed the leseb:cv-skip-restorecon branch from aa30458 to a0fdf1b Nov 12, 2019
@leseb leseb merged commit 496e6e5 into rook:master Nov 12, 2019
5 checks passed
5 checks passed
DCO DCO
Details
Rule: backport release-1.1 (backport) Backports have been created
Details
Summary 1 rule matches
Details
commitlint found 0 problems, 0 warnings
continuous-integration/jenkins/pr-head This commit looks good
Details
@leseb leseb deleted the leseb:cv-skip-restorecon branch Nov 12, 2019
leseb added a commit that referenced this pull request Nov 12, 2019
Ceph-volume skip restorecon (bp #4260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.