Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: default the device set template name to data #5524

Merged
merged 1 commit into from May 21, 2020
Merged

ceph: default the device set template name to data #5524

merged 1 commit into from May 21, 2020

Conversation

travisn
Copy link
Member

@travisn travisn commented May 21, 2020

Description of your changes:
In 1.3 we added support for the metadata pvcs, thus requiring the name to be set on the templates to differentiate between data and metadata. For backward compatibility we need to assume the template is for data if it is not set.

Also added a much needed unit test for generating the device set PVCs.

Checklist:

  • CommitLint Bot: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

[test ceph]

@travisn travisn requested review from leseb and galexrt May 21, 2020 17:25
@travisn
ceph: default the device set template name to data
8bb4f60 
In 1.3 we added support for the metadata pvcs, thus requiring the name
to be set on the templates to differentiate between data and metadata.
For backward compatibility we need to assume the template is for data
if it is not set.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested a review from BlaineEXE May 21, 2020 18:14
@travisn travisn merged commit f8256f8 into rook:master May 21, 2020
@travisn travisn deleted the data-name-default branch May 21, 2020 19:53
@mergify mergify bot mentioned this pull request May 21, 2020
Merged
mergify bot added a commit that referenced this pull request May 21, 2020
@mergify
Merge pull request #5527 from rook/mergify/bp/release-1.3/pr-5524
fdd07d2 
ceph: default the device set template name to data (bp #5524)
@travisn travisn mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbw976 jbw976 jbw976 approved these changes

@leseb leseb Awaiting requested review from leseb

@galexrt galexrt Awaiting requested review from galexrt

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @jbw976