ceph: ability to set external services ports #6714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
leseb
force-pushed
the
mgr-port-config-external-simple
branch
3 times, most recently
from
b66653e
to
b3cc62c
Compare
umangachapagain
requested changes
Nov 30, 2020
leseb
force-pushed
the
mgr-port-config-external-simple
branch
from
b3cc62c
to
7b8bf81
Compare
umangachapagain
approved these changes
Dec 1, 2020
leseb
force-pushed
the
mgr-port-config-external-simple
branch
from
7b8bf81
to
4004676
Compare
travisn
requested changes
Dec 1, 2020
leseb
force-pushed
the
mgr-port-config-external-simple
branch
from
4004676
to
4912016
Compare
leseb
force-pushed
the
mgr-port-config-external-simple
branch
from
4912016
to
ef3838f
Compare
leseb
force-pushed
the
mgr-port-config-external-simple
branch
2 times, most recently
from
ae6e10b
to
3a2a3f1
Compare
travisn
reviewed
Dec 3, 2020
When the cluster is external we want to expose manager service port along with the endpoints. This allows us to connect but Rook will keep on using 9283 as a facing port for Prometheus and more. ``` monitoring: enabled: true ... ... externalMgrPrometheusPort: 9283 ``` Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
mgr-port-config-external-simple
branch
from
3a2a3f1
to
8aaff23
Compare
travisn
approved these changes
Dec 4, 2020
mergify bot
added a commit
that referenced
this pull request
Dec 4, 2020
ceph: ability to set external services ports (bp #6714)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
When the cluster is external we want to expose manager service port
along with the endpoints.
This allows us to connect but Rook will keep on using 9283 as a facing
port for Prometheus and more.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.