ceph: auto detect vault k/v version #8265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
6bc05b8
to
d30cedf
Compare
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
d30cedf
to
9e2a4a3
Compare
thotz
reviewed
Jul 9, 2021
thotz
reviewed
Jul 9, 2021
| backendPath = vault.DefaultBackendPath | ||
| } | ||
|
|
||
| backend := GetParam(secretConfig, vault.VaultBackendKey) |
There was a problem hiding this comment.
Why do we need to still support this if there is auto-detection? This won't have a backward compatibility issue right?
There was a problem hiding this comment.
Whoever passes a parameter expects it to be interpreted even if it happens to be incorrect. This could be useful for checking errors too.
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
8 times, most recently
from
90863ca
to
dbcdb26
Compare
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
dbcdb26
to
8198084
Compare
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
4 times, most recently
from
4357d51
to
d4444f2
Compare
thotz
reviewed
Jul 21, 2021
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
d4444f2
to
e08e7d1
Compare
travisn
approved these changes
Jul 27, 2021
| } | ||
|
|
||
| switch GetParam(securitySpec.KeyManagementService.ConnectionDetails, Provider) { | ||
| case "vault": |
There was a problem hiding this comment.
Should it be an error case if the provider is not vault?
| return errors.Errorf("failed to read k8s kms secret %q key %q (not found or empty)", KMSTokenSecretNameKey, securitySpec.KeyManagementService.TokenSecretName) | ||
| secretEngine := securitySpec.KeyManagementService.ConnectionDetails[VaultSecretEngineKey] | ||
| switch secretEngine { | ||
| case VaultKVSecretEngineKey: |
There was a problem hiding this comment.
An error case if this is not the case?
There was a problem hiding this comment.
No we also support the transit engine, so we don't need to error here.
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
e08e7d1
to
2b741e8
Compare
Rook will now auto detect the kv version of the vault server. This allows users not having to pass the VAULT_BACKEND configuration in the CephCluster CR. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
auto-detect-vault-kv-version
branch
from
2b741e8
to
99e00de
Compare
leseb
added a commit
that referenced
this pull request
Jul 29, 2021
ceph: auto detect vault k/v version (backport #8265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rook will now auto detect the kv version of the vault server. This
allows users not having to pass the VAULT_BACKEND configuration in the
CephCluster CR.
Signed-off-by: Sébastien Han seb@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.