ceph: proxy rbd commands when multus is enabled #8339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
multus-rbd-commands
branch
4 times, most recently
from
f67c3ea
to
591c587
Compare
We now pass the networking spec to the clusterInfo so that the executor can make the right decision on how to execute a command. This is a small change that allows us to remove the CephBlockPool CR since it's checking for rbd images. On a Multus deployment, the operator does not have the network annotations, thus has no access to the OSD network then rbd commands are hanging forever. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
multus-rbd-commands
branch
from
591c587
to
1900160
Compare
travisn
approved these changes
Jul 20, 2021
| @@ -45,6 +45,7 @@ type ClusterInfo struct { | |||
| // If the CR name is needed, access it through the NamespacedName() method. | |||
| name string | |||
| OsdUpgradeTimeout time.Duration | |||
| NetworkSpec cephv1.NetworkSpec | |||
There was a problem hiding this comment.
I'm going back and forth considering if this should just be a setting like:
ExecuteRBDRemotely boolBut I can see how the network spec may be useful in the future if there are other places we need the network settings, so let's go with the the network spec as you have it.
There was a problem hiding this comment.
Also ExecuteRBDRemotely would be too restrictive and won't reflect well with the type's name.
mergify bot
added a commit
that referenced
this pull request
Jul 20, 2021
ceph: proxy rbd commands when multus is enabled (backport #8339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We now pass the networking spec to the clusterInfo so that the executor
can make the right decision on how to execute a command.
This is a small change that allows us to remove the CephBlockPool CR
since it's checking for rbd images. On a Multus deployment, the operator
does not have the network annotations, thus has no access to the OSD
network then rbd commands are hanging forever.
Signed-off-by: Sébastien Han seb@redhat.com
Checklist:
make codegen) has been run to update object specifications, if necessary.