csi: default to ReadWriteOnceWithFSType for cephfs #9729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Need change at below places
https://github.com/rook/rook/blob/master/deploy/examples/operator.yaml#L71
https://github.com/rook/rook/blob/master/deploy/examples/operator-openshift.yaml#L153
Do we need documentation to change this value in upgraded clusters?
``` ReadWriteOnceWithFSType: Indicates that volumes will be examined to determine if volume ownership and permissions should be modified to match the pod's security policy. Changes will only occur if the fsType is defined and the persistent volume's accessModes contains ReadWriteOnce. ``` In between considering we are giving 0777 permission on nodestage of cephfs shares, we defaulted to NONE. However giving worldwide permission to the volume is not the right thing and it has been fixed in cephfs via ceph/ceph-csi#2847 This commit brings it back to the value which is also in parity with RBD driver. Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
force-pushed
the
final-fsgroup
branch
from
9ab79fc
to
6561bda
Compare
Considering the changes are opt in and out as always, we dont need to ask the users I believe. |
|
@Madhu-1 can you revisit the PR? |
Madhu-1
approved these changes
Feb 14, 2022
leseb
approved these changes
Feb 14, 2022
|
Yeah, afaict, it should be fine to pick the change even in absence of CSI fix @travisn |
mergify bot
added a commit
that referenced
this pull request
Feb 28, 2022
csi: default to ReadWriteOnceWithFSType for cephfs (backport #9729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In between considering we are giving 0777 permission on nodestage
of cephfs shares, we defaulted to NONE. However giving worldwide
permission to the volume is not the right thing and it has been
fixed in cephfs via ceph/ceph-csi#2847
This commit brings it back to the value which is also in parity
with RBD driver.
Signed-off-by: Humble Chirammal hchiramm@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.