Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix csi-cephfsplugin pod restart on non-hostnetworking env #9925

Merged
merged 3 commits into from Apr 27, 2022

Conversation

leseb
Copy link
Member

@leseb leseb commented Mar 17, 2022

Description of your changes:

Implementation of the design proposed in
#9903.

Signed-off-by: Sébastien Han seb@redhat.com

Checklist:

  • Helm intgegration
  • Doc? for Helm?

@leseb leseb changed the title core: fix csifs plugin pod restart on non-hostnetworking env core: fix csi-cephfsplugin pod restart on non-hostnetworking env Mar 17, 2022
@leseb leseb force-pushed the multus-plugin-restart-fix branch from 6a1a322 to d15f5e2 Compare March 18, 2022 14:34
@leseb leseb added this to Review in Progress in v1.9 via automation Mar 23, 2022
@leseb leseb force-pushed the multus-plugin-restart-fix branch from d15f5e2 to 9bc3d19 Compare March 31, 2022 14:38
@travisn travisn moved this from Review in Progress to In progress in v1.9 Apr 1, 2022
@travisn travisn removed this from In progress in v1.9 Apr 1, 2022
@leseb leseb force-pushed the multus-plugin-restart-fix branch 10 times, most recently from a894455 to ec7870d Compare April 12, 2022 13:49
@leseb
Copy link
Member Author

leseb commented Apr 12, 2022

CI extracted in #10048

@leseb leseb force-pushed the multus-plugin-restart-fix branch from ec7870d to b31a13b Compare April 12, 2022 14:39
@mergify
Copy link

mergify bot commented Apr 12, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the multus-plugin-restart-fix branch 2 times, most recently from ad3a76c to 94778a1 Compare April 12, 2022 16:26
@mergify
Copy link

mergify bot commented Apr 12, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the multus-plugin-restart-fix branch 2 times, most recently from e976d9b to 3e692e1 Compare April 13, 2022 08:08
@leseb leseb force-pushed the multus-plugin-restart-fix branch 4 times, most recently from 376f6da to 28074d3 Compare April 13, 2022 14:20
@leseb leseb force-pushed the multus-plugin-restart-fix branch 5 times, most recently from e14576b to 2f9a695 Compare April 25, 2022 13:14
@leseb leseb requested a review from Madhu-1 April 26, 2022 07:47
pkg/operator/ceph/csi/cluster_config.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/cluster_config.go Show resolved Hide resolved
pkg/operator/ceph/csi/cluster_config.go Show resolved Hide resolved
pkg/operator/ceph/csi/controller.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
The CSI package needs to load clusterInfo, today this code is in the mon
package which makes the call of LoadClusterInfo impossible without
having a circular import.

Signed-off-by: Sébastien Han <seb@redhat.com>
The CI runs will now collect all the secrets and configmaps available.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb force-pushed the multus-plugin-restart-fix branch 4 times, most recently from ac7c522 to 8ef6819 Compare April 26, 2022 09:53
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more things to take care of. LGTM

pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
@leseb leseb force-pushed the multus-plugin-restart-fix branch 3 times, most recently from d49bad2 to 44348e3 Compare April 26, 2022 12:39
@leseb leseb requested a review from Madhu-1 April 26, 2022 14:15
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small suggestions

pkg/operator/ceph/csi/controller.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/csi/spec.go Outdated Show resolved Hide resolved
Implementation of the design proposed in
rook#9903.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb force-pushed the multus-plugin-restart-fix branch from 44348e3 to 73b1347 Compare April 26, 2022 15:53
@leseb leseb requested a review from travisn April 26, 2022 15:57
@leseb leseb merged commit ed3121d into rook:master Apr 27, 2022
@leseb leseb deleted the multus-plugin-restart-fix branch April 27, 2022 09:42
@leseb leseb moved this from Review in Progress to Done in v1.9 Apr 27, 2022
mergify bot added a commit that referenced this pull request Apr 27, 2022
core: fix csi-cephfsplugin pod restart on non-hostnetworking env (backport #9925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1.9
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants