Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Dev dependencies are not installed when installed from npm #713

Closed
alallier opened this issue May 20, 2019 · 0 comments · Fixed by #715 or #718
Closed

Regression: Dev dependencies are not installed when installed from npm #713

alallier opened this issue May 20, 2019 · 0 comments · Fixed by #715 or #718
Assignees
@Autre31415
Labels
bug in progress Issue that is currently being worked on P1 Highest Priority

Comments

@alallier
Copy link
Member

alallier commented May 20, 2019 •
edited
Loading

I haven't found the documentation on this yet but it seems when you declare/install a dependency in your project it will not install any devDependencies. I guess this as seen as any declared devDependencies are used to develop Roosevelt itself. But stuff like html-validator are used in Roosevelt outside of development, just used in development mode

I think we looked at this wrong

Caused by: #709
@alallier alallier changed the title Regression: Dev dependencies are not installed when install from npm Regression: Dev dependencies are not installed when installed from npm May 20, 2019
@kethinov kethinov added bug in progress Issue that is currently being worked on P1 Highest Priority labels May 20, 2019
@Autre31415 Autre31415 mentioned this issue May 20, 2019
Merged
kethinov added a commit to kethinov/roosevelt that referenced this issue May 20, 2019
@kethinov
0.14.2
ce85a36 
## 0.14.2

- Reverted most changes in 0.14.1 to fix [rooseveltframework#713](rooseveltframework#713), but preserved modularization of htmlValidator.js so that if any devDependencies are missing, the app will not crash in production mode.
- Various dependencies bumped.
@kethinov kethinov mentioned this issue May 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Autre31415 Autre31415

Labels
bug in progress Issue that is currently being worked on P1 Highest Priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset dependencies Autre31415/roosevelt
0.14.2 kethinov/roosevelt
3 participants
@kethinov @Autre31415 @alallier