New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF] Bug in RooSimultaneous::extendMode() #6894
Comments
A related problem is also in RooNLLVar::create that is called by RooAbsTestStatistic::initSimMode, When the sub-likelihood is created using the component pdf, one should pass the extend flag only if the pdf canBeExtended() |
For returning the extend mode examine all the pdf in the list and flag as CanExtend or MustExtend if just one of the pdf can be extended. Fix also passing the extended flags when creating the sub-NLL in RooNLLVar::create(). If one of the sim component cannot be extended then switch off the extended flag for that component. Before it was passed for all components. This fixes issue root-project#6894
For returning the extend mode examine all the pdf in the list and flag as CanExtend or MustExtend if just one of the pdf can be extended. Fix also passing the extended flags when creating the sub-NLL in RooNLLVar::create(). If one of the sim component cannot be extended then switch off the extended flag for that component. Before it was passed for all components. This fixes issue root-project#6894
For returning the extend mode examine all the pdf in the list and flag as CanExtend or MustExtend if just one of the pdf can be extended. Fix also passing the extended flags when creating the sub-NLL in RooNLLVar::create(). If one of the sim component cannot be extended then switch off the extended flag for that component. Before it was passed for all components. This fixes issue #6894
For returning the extend mode examine all the pdf in the list and flag as CanExtend or MustExtend if just one of the pdf can be extended. Fix also passing the extended flags when creating the sub-NLL in RooNLLVar::create(). If one of the sim component cannot be extended then switch off the extended flag for that component. Before it was passed for all components. This fixes issue root-project#6894
Hello, In root-6.24, I have the impression that this fix unfortunately seems to imply a crash in evaluate : when there is a non-extendable category and an extendable one in the RooSimultaneous, canBeExtended() will be true, and then expectedEvents will be called also for the non extendable category, and this will make the code crashes, I think. Running the macro posted here https://root-forum.cern.ch/t/use-of-roosimultaneous-pdf-with-mustbeextended-and-cannotbeextended-pdfs/42462 within 6.24, I get Best, Jean-Baptiste |
When a simultaneous pdf is composed by a not-extended pdf and an extended pdf, RooSimultaneous::extendMode() returns
MustBeExtended
orCanNotBeExtended
depending on the initial category value.See example and report on
https://root-forum.cern.ch/t/use-of-roosimultaneous-pdf-with-mustbeextended-and-cannotbeextended-pdfs/42462
The text was updated successfully, but these errors were encountered: