Skip to content

Conversation

@Phmonski
Copy link
Contributor

This Pull request:

  • New features and improvements for HS3

Changes or fixes:

  • Added RooEffProd Class
  • Changed Flag handling: Exclude nbins from "parameter_points" and "const" from data "axes"
  • New Streamer/Factory Class for ParamHistFunc
  • ParamHistFunc now accepts custom modifiers
  • Code clean up

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Test Results

    22 files      22 suites   4d 1h 9m 9s ⏱️
 3 776 tests  3 775 ✅ 0 💤 1 ❌
81 133 runs  81 132 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a7c2217.

♻️ This comment has been updated with latest results.

@TomasDado
Copy link
Contributor

Hello, if possible, could this the changes in this code, once merged, be propagated to 6.38? These fixes are needed to publish the full likelihood in one of the ATLAS analysis, and we want to use a tagged version of the code for this.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM

@guitargeek guitargeek merged commit e42fe7c into root-project:master Nov 14, 2025
28 of 30 checks passed
@guitargeek
Copy link
Contributor

Hello, if possible, could this the changes in this code, once merged, be propagated to 6.38? These fixes are needed to publish the full likelihood in one of the ATLAS analysis, and we want to use a tagged version of the code for this.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants