Skip to content

[math] add vector of vector of floats dict as with double #20464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

[math] add vector of vector of floats dict as with double #20464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c748726
[math] add vector of vector of floats dict as with double
ferdymercury Nov 19, 2025
1ae2c77
[test][RDF] vector of vector of floats no longer throws
ferdymercury Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions math/mathcore/inc/LinkDef2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@
#pragma link C++ class ROOT::Math::DistSamplerOptions+;
#pragma link C++ class ROOT::Math::GoFTest+;
#pragma link C++ class std::vector<std::vector<double> >+;
#pragma link C++ class std::vector<std::vector<float> >+;

#pragma link C++ class ROOT::Math::Delaunay2D+;

Expand Down
3 changes: 1 addition & 2 deletions tree/dataframe/test/dataframe_utils.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,7 @@ TEST(RDataFrameUtils, TypeName2TypeID)
{
EXPECT_EQ(typeid(float), RDFInt::TypeName2TypeID("float"));
EXPECT_EQ(typeid(std::vector<float>), RDFInt::TypeName2TypeID("std::vector<float>"));
EXPECT_EQ(typeid(std::vector<std::vector<float>>), RDFInt::TypeName2TypeID("std::vector<std::vector<float>>"));
EXPECT_THROW(RDFInt::TypeName2TypeID("float *"), std::runtime_error);
EXPECT_THROW(RDFInt::TypeName2TypeID("float &"), std::runtime_error);
// TODO(jblomer): Ideally, we would want the next one not to throw an exception
EXPECT_THROW(RDFInt::TypeName2TypeID("std::vector<std::vector<float>>"), std::runtime_error);
}
Loading