[RDF] Fix snapshotting Defines that implicitly depend on variations #20512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RActionSnapshot did not create the varied versions of Defines. Therefore, Defines that implicitly depended on a variation were identical to nominal, and did not get snapshot. Here, the computation graph is JITted and the variations of Defines are created when the snapshot action gets created. Fix root-project#20506
hageboeck
force-pushed
the
20506_snapshotMissingColumns
branch
from
37ba327 to
dd1e022
Compare
martamaja10
approved these changes
Nov 25, 2025
Contributor
martamaja10
left a comment
martamaja10
left a comment
There was a problem hiding this comment.
Thank you Stephan, LGTM!
Test Results 22 files 22 suites 3d 18h 25m 19s ⏱️ Results for commit dd1e022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RActionSnapshot did not create the varied versions of Defines.
Therefore, Defines that implicitly depended on a variation were
identical to nominal, and did not get snapshot.
Here, the computation graph is JITted and the variations of Defines are
created when the snapshot action gets created.
Fix #20506