Skip to content

[vecops] Alignment-related fix for getting first element of small vector #20541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[vecops] Alignment-related fix for getting first element of small vector #20541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion math/vecops/inc/ROOT/RVec.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ class R__CLING_PTRCHECK(off) SmallVectorTemplateCommon : public SmallVectorBase
/// SmallVectorStorage is properly-aligned even for small-size of 0.
void *getFirstEl() const
{
return const_cast<void *>(reinterpret_cast<const void *>(reinterpret_cast<const char *>(this) +
// get the SmallVectorBase subobject inside RVec
auto *base = static_cast<const SmallVectorBase *>(this);
return const_cast<void *>(reinterpret_cast<const void *>(reinterpret_cast<const char *>(base) +
offsetof(SmallVectorAlignmentAndSize<T>, FirstEl)));
}
// Space after 'FirstEl' is clobbered, do not add any instance vars after it.
Expand Down
Loading