[vecops] Adaptive size of long RVec instances in RVec test #20543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 21h 2m 39s ⏱️ Results for commit bd71f9b. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
rvec_tests
branch
from
25902ea to
bd71f9b
Compare
guitargeek
changed the title
vepadulano
reviewed
Nov 27, 2025
For the tests to make sense, some vectors need to be longer than the maximum small vector size. This maximum size is compiler and architecture dependent. For `RVec<int>` on ARM64 with gcc 14, the small vector capacity turns out to be 60, which is larger than the current test vector size of 18. Therefore, the test is refactored to adapt the large vector size automatically, according to the maximum small vector size.
guitargeek
force-pushed
the
rvec_tests
branch
from
bd71f9b to
aac0dde
Compare
guitargeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the tests to make sense, some vectors need to be longer than the
maximum small vector size. This maximum size is compiler and
architecture dependent. For
RVec<int>on ARM64 with gcc 14, thesmall vector capacity turns out to be 60, which is larger than the
current test vector size of 18.
Therefore, the test is refactored to adapt the large vector size
automatically, according to the maximum small vector size.
We can see in another PR how the commit in this PR would be doing on Alma 10 ARM 64 (gcc 14):