Const polynomial roots #20544
Open
Const polynomial roots #20544
+75
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hageboeck
reviewed
Nov 27, 2025
meiyasan
force-pushed
the
polynomial-with-const
branch
from
5c02ff4 to
162c758
Compare
Test Results 22 files 22 suites 4d 2h 10m 31s ⏱️ For more details on these failures, see this check. Results for commit 81dc8f0. ♻️ This comment has been updated with latest results. |
meiyasan
force-pushed
the
polynomial-with-const
branch
from
162c758 to
81dc8f0
Compare
vepadulano
approved these changes
Nov 28, 2025
- Remove unused `fRoots` data member (it was cleared before each root
computation and provided no persistent state).
- Return polynomial roots by value instead of via internal storage.
- Mark the affected query/utility methods as `const` to make the class
usable in const contexts.
- Apply clang-format to the modified sections.
vepadulano
force-pushed
the
polynomial-with-const
branch
from
81dc8f0 to
e886db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Hi @hageboeck @vepadulano ; This is a followup on my previous PR #20524 #20539
Changes or fixes:
Checklist:
Tests:
I ran the ROOT battery of tests with couple of issues.
Regarding the Polynomial class modifications, my use case output remains unchanged. (I use polynomials to compute digital filtering, biquad, etc..) I also paid attention in particular to those related to polynomials:
gtest-hist-hist-testTProfile2Poly, etc..