From e44bf789bcd9bcca2b285288d858da73b1690ae1 Mon Sep 17 00:00:00 2001 From: Jonas Rembser Date: Sun, 26 Apr 2026 13:28:47 +0200 Subject: [PATCH] [RF] Remove remnant setOperMode() in the RooFit::Evaluator constructor Follows up on fa977749042b74, which ensures that the mutation of the computation graphs operation mode is is only happening during minimization. There was a remnant `setOperMode(RooAbsArg::ADirty)` in the evaluator constructor that can now be removed. --- roofit/roofitcore/src/RooFit/Evaluator.cxx | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/roofit/roofitcore/src/RooFit/Evaluator.cxx b/roofit/roofitcore/src/RooFit/Evaluator.cxx index b17fc94cbe598..06ced37a724a4 100644 --- a/roofit/roofitcore/src/RooFit/Evaluator.cxx +++ b/roofit/roofitcore/src/RooFit/Evaluator.cxx @@ -326,17 +326,6 @@ void Evaluator::updateOutputSizes() for (auto &info : _nodes) { info.outputSize = outputSizeMap.at(info.absArg); info.isDirty = true; - // We don't need dirty flag propagation because the evaluator takes care - // of deciding what needs to be re-evaluated. We can disable the regular - // dirty state propagation. However, fundamental variables like - // RooRealVars and RooCategories are usually shared with other - // computation graphs outside the evaluator, so they can't be mutated. - // See also the code of the RooMinimizer, which ensures that dirty state - // propagation is temporarily disabled during minimization to really - // eliminate any overhead from the dirty flag propagation. - if (!info.absArg->isFundamental()) { - setOperMode(info.absArg, RooAbsArg::ADirty); - } } if (_useGPU) {