Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Add operations needed for performing optimizer updates: #2315

Merged
merged 1 commit into from Jul 23, 2018

Conversation

@ravikiran0606
Copy link
Contributor

@ravikiran0606 ravikiran0606 commented Jul 12, 2018

  • Implement ConstAdd, ConstMult, ReciprocalElementWise, SquareElementWise, SqrtElementWise in CPU, GPU and Reference architectures.

  • Add Unit Tests for them in CPU, GPU architecture.

  • Add ROOT Style docs and clang format the code.

@ravikiran0606 ravikiran0606 requested a review from lmoneta as a code owner Jul 12, 2018
@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 12, 2018

Can one of the admins verify this patch?

@Axel-Naumann
Copy link
Member

@Axel-Naumann Axel-Naumann commented Jul 13, 2018

Please rebase onto master (rewriting this branch's history) instead of creating merge commits.

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Jul 13, 2018

@Axel-Naumann Yeah I was trying to do that! I'll rebase into master and update this PR.

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Jul 15, 2018

I have rebased into master and updated the PR. @lmoneta @stwunsch Can you please review this?

@stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Jul 15, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 15, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 15, 2018

Build failed on centos7/clang39.
See console output.

Errors:

  • ERROR: Timeout after 30 minutes
  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Timeout after 30 minutes
  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Error fetching remote repo 'origin'

@xvallspl
Copy link
Contributor

@xvallspl xvallspl commented Jul 16, 2018

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 16, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Jul 17, 2018

@stwunsch Can you please trigger the build?

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Jul 17, 2018

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 17, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

Copy link
Member

@lmoneta lmoneta left a comment

Hi,
Do we really need these functions to be implemented for all architectures ?
In this case we miss the GPU implementation.
I think since these functions affect the optimiser, maybe they could be implemented for only one type of matrices, the reference one. To be discussed

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Jul 17, 2018

Looking carefully at the code, I see that we need to have a GPU implementations for these functions.
As a first attempt we could try by doing in term of TMatrixT using the conversions TCudaMatrix -> Matrix functions and then we check if it is really needed to have something specific for GPU's

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 17, 2018

Build failed on slc6/gcc48.
See console output.

Errors:

  • ERROR: Timeout after 30 minutes
  • ERROR: Error cloning remote repo 'origin'
  • ERROR: Error cloning remote repo 'origin'

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Jul 18, 2018

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 18, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 18, 2018

Build failed on slc6-i686/gcc49.
See console output.

Errors:

  • ERROR: Timeout after 30 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Jul 19, 2018

@lmoneta @stwunsch I ll add the GPU implementation for those Operations soon and update this PR. We can merge then !

* Implement ConstAdd, ConstMult, ReciprocalElementWise, SquareElementWise, SqrtElementWise in CPU, GPU and Reference architectures.

* Add Unit Tests for them in CPU, GPU architecture.

* Add ROOT Style docs and clang format the code.
@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Jul 19, 2018

@stwunsch @lmoneta I added the GPU implementation for those operations and both the CPU and GPU tests are passing. Can you review and trigger the build?

The update operations tests are as follows,

update operations

update operations tests

@stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Jul 20, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Jul 20, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@stwunsch stwunsch merged commit a85bdf0 into root-project:master Jul 23, 2018
2 checks passed
@ravikiran0606 ravikiran0606 deleted the Update-Operations branch Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants