Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Refactor MethodDL Tests for Optimization. #2379

Merged
merged 1 commit into from Aug 2, 2018

Conversation

4 participants
@ravikiran0606
Copy link
Contributor

commented Jul 27, 2018

  • I have refactored the existing methodDL tests to support testing various optimizers.

@ravikiran0606 ravikiran0606 requested review from amadio and lmoneta as code owners Jul 27, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Can one of the admins verify this patch?

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2018

@stwunsch @lmoneta Can you please review this PR?

@stwunsch

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2018

@phsft-bot build

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Build failed on fedora28/native.
See console output.

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/core/meta/src/TClass.cxx:686:14: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rpdutils/src/rpdutils.cxx:5203:14: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rpdutils/src/rpdutils.cxx:4757:26: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 10 bytes from a string of length 10 [-Wstringop-truncation]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rootd/src/rootd.cxx:490:14: warning: ‘char* strncat(char*, const char*, size_t)’ accessing between 2147483648 and 2147483647 bytes at offsets 0 and [-2147483647, 2147483648] may overlap 1 byte at offset [0, 4294967295] [-Wrestrict]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rootd/src/rootd.cxx:761:21: warning: ‘%lu’ directive writing between 1 and 20 bytes into a region of size between 0 and 8191 [-Wformat-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/proof/proofd/src/XrdProofdProtocol.cxx:527:45: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class XrdSecEntity’; use assignment or value-initialization instead [-Wclass-memaccess]
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TSystem.cxx:1148:14: warning: ‘char* strncat(char*, const char*, size_t)’ accessing 1 byte at offsets 0 and [-2147483647, 2147483648] may overlap 1 byte at offset [0, 2147483649] [-Wrestrict]
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TROOT.cxx:1770:96: warning: cast between incompatible function types from ‘TVirtualPad*& ()()’ to ‘TGlobalMappedFunction::GlobalFunc_t’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TROOT.cxx:1774:94: warning: cast between incompatible function types from ‘TVirtualX*& ()()’ to ‘TGlobalMappedFunction::GlobalFunc_t’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/core/base/src/TROOT.cxx:1776:95: warning: cast between incompatible function types from ‘TDirectory*& ()()’ to ‘TGlobalMappedFunction::GlobalFunc_t’ {aka ‘void (*)()’} [-Wcast-function-type]

And 92 more

Failing tests:

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Build failed on centos7/gcc7.
See console output.

Warnings:

  • ../root/core/newdelete/src/NewDelete.cxx:217:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:344:11: warning: ‘operator new’ must not return NULL unless it is declared ‘throw()’ (or -fcheck-new is in effect)
  • ../root/core/newdelete/src/NewDelete.cxx:263:6: warning: the program should also define ‘void operator delete(void*, std::size_t)’ [-Wsized-deallocation]
  • ../root/core/newdelete/src/NewDelete.cxx:367:6: warning: the program should also define ‘void operator delete [](void*, std::size_t)’ [-Wsized-deallocation]

Failing tests:

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Build failed on slc6-i686/gcc49.
See console output.

Errors:

  • ERROR: Timeout after 5 minutes
  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Error fetching remote repo 'origin'

Failing tests:

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2018

I made one mistake. I tested the methodDL with locally downloaded tmva_class_example.root file. I forgot to change that to use the one on http://root.cern.ch/files/tmva_class_example.root. I guess that might be the cause of the test failure.

@ravikiran0606 ravikiran0606 force-pushed the ravikiran0606:Refactor-Tests branch from 20e94a7 to 1ac7377 Jul 27, 2018

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2018

@stwunsch I updated the PR with the correction. Can you trigger the build?

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Build failed on windows10/vc15.
See console output.

Errors:

  • ERROR: Error fetching remote repo 'origin'
  • ERROR: Error fetching remote repo 'origin'
@stwunsch

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2018

@phsft-bot build

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

",Momentum=0.9,Repetitions=1,"
"ConvergenceSteps=20,BatchSize=256,TestRepetitions=10,"
"WeightDecay=1e-4,Regularization=L2,"
"DropConfig=0.0+0.5+0.5+0.5, Multithreading=True");

This comment has been minimized.

Copy link
@lmoneta

lmoneta Aug 2, 2018

Contributor

There is an error in the string definition here. You cannot have a whitespace in the string.
Also the Multithreading option can be removed because it is not activated.
However this is fixed by my PR #2219.
I would merge the PR anyway and then I will fix that when fixing the conflicts I will get in #2219

This comment has been minimized.

Copy link
@ravikiran0606

ravikiran0606 Aug 2, 2018

Author Contributor

Hmm okay!

@lmoneta lmoneta merged commit ee3a4ec into root-project:master Aug 2, 2018

2 checks passed

Jenkins CI build Build passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ravikiran0606 ravikiran0606 deleted the ravikiran0606:Refactor-Tests branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.