Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Add API Support for Adam Optimizer. #2438

Merged
merged 1 commit into from Aug 7, 2018

Conversation

4 participants
@ravikiran0606
Copy link
Contributor

commented Aug 5, 2018

  • Implement Adam Optimizer.
  • Add Unit tests and MethodDL tests.

Reference Implementation: Tensorflow Adam Optimizer

@ravikiran0606 ravikiran0606 requested a review from lmoneta as a code owner Aug 5, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2018

Can one of the admins verify this patch?

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

@lmoneta @stwunsch Can you please review?

@stwunsch

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

@phsft-bot build

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2018

@ravikiran0606 ravikiran0606 force-pushed the ravikiran0606:Adam-Optimizer branch from 8051a18 to f06c144 Aug 7, 2018

@ravikiran0606 ravikiran0606 requested a review from amadio as a code owner Aug 7, 2018

@lmoneta

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

@phsft-bot build !

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2018

@lmoneta @stwunsch I guess we are good to merge this PR. Once this is merged, I'll rebase and update the next PR for Adagrad optimizer.

@lmoneta lmoneta merged commit 6e27f3c into root-project:master Aug 7, 2018

2 checks passed

Jenkins CI build Build passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ravikiran0606 ravikiran0606 deleted the ravikiran0606:Adam-Optimizer branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.