Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Add API Support for RMSProp Optimizer: #2440

Merged
merged 1 commit into from Aug 9, 2018

Conversation

@ravikiran0606
Copy link
Contributor

@ravikiran0606 ravikiran0606 commented Aug 5, 2018

  • Implement RMSProp Optimizer.
  • Add Unit tests and MethodDL tests.

Reference Implementation: Tensorflow RMSProp Optimizer

@ravikiran0606 ravikiran0606 requested a review from lmoneta as a code owner Aug 5, 2018
@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Aug 5, 2018

Can one of the admins verify this patch?

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Aug 5, 2018

@lmoneta @stwunsch Can you please review? And for RMSProp the meanAbsoluteError is of the order of 1e-2. So I would like to discuss on the threshold value for testing the optimizer.

@ravikiran0606 ravikiran0606 changed the title [TMVA] Add API Support for RMSProp Optimizer: [TMVA] [DNM] Add API Support for RMSProp Optimizer: Aug 5, 2018
@stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Aug 6, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Aug 6, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@ravikiran0606 ravikiran0606 changed the title [TMVA] [DNM] Add API Support for RMSProp Optimizer: [TMVA] [Do Not Merge] Add API Support for RMSProp Optimizer: Aug 6, 2018
@ravikiran0606 ravikiran0606 changed the title [TMVA] [Do Not Merge] Add API Support for RMSProp Optimizer: [TMVA] Add API Support for RMSProp Optimizer: Aug 8, 2018
@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Aug 8, 2018

@stwunsch @lmoneta I updated the PR with the new changes as we discussed. Can you now review and trigger the build?

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Aug 8, 2018

@phsft-bot build !

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Aug 8, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Aug 8, 2018

@stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Aug 8, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

@phsft-bot phsft-bot commented Aug 8, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@ravikiran0606
Copy link
Contributor Author

@ravikiran0606 ravikiran0606 commented Aug 8, 2018

@lmoneta @stwunsch I guess we are good to merge this 😄

@lmoneta lmoneta merged commit 44c7cf3 into root-project:master Aug 9, 2018
2 checks passed
@ravikiran0606 ravikiran0606 deleted the RMSProp-Optimizer branch Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants