Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Add API Support for Adadelta Optimizer. #2441

Merged
merged 1 commit into from Aug 9, 2018

Conversation

4 participants
@ravikiran0606
Copy link
Contributor

commented Aug 5, 2018

  • Implement Adagrad Optimizer.
  • Add Unit tests and MethodDL tests.

Reference Implementation: Tensorflow Adadelta Optimizer

@ravikiran0606 ravikiran0606 requested a review from lmoneta as a code owner Aug 5, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2018

Can one of the admins verify this patch?

@ravikiran0606 ravikiran0606 changed the title [TMVA] Add API Support for Adadelta Optimizer. [TMVA] [DNM] Add API Support for Adadelta Optimizer. Aug 5, 2018

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

@lmoneta @stwunsch Can you please review? And for Adadelta the meanAbsoluteError is of the order of 1e-3. So I would like to discuss on the threshold value for testing the optimizer.

@stwunsch

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

@phsft-bot build

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@ravikiran0606 ravikiran0606 changed the title [TMVA] [DNM] Add API Support for Adadelta Optimizer. [TMVA] [Do Not Merge] Add API Support for Adadelta Optimizer. Aug 6, 2018

@stwunsch

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

@ravikiran0606 Can you rebase this PR?

@ravikiran0606 ravikiran0606 force-pushed the ravikiran0606:Adadelta-Optimizer branch from 24b7791 to 481ca7f Aug 9, 2018

@ravikiran0606 ravikiran0606 requested a review from amadio as a code owner Aug 9, 2018

@ravikiran0606 ravikiran0606 changed the title [TMVA] [Do Not Merge] Add API Support for Adadelta Optimizer. [TMVA] Add API Support for Adadelta Optimizer. Aug 9, 2018

@ravikiran0606 ravikiran0606 force-pushed the ravikiran0606:Adadelta-Optimizer branch from 481ca7f to f765fd2 Aug 9, 2018

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@stwunsch @lmoneta I rebased the PR. Can you please trigger the build?

@lmoneta

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

@phsft-bot build !

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@lmoneta

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

Hi Ravi,
Can you add MaxEpochs=50 or even less in the test to avoid the timeout. We should also understand why the test error continues to decrease

Lorenzo

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

@ravikiran0606 ravikiran0606 force-pushed the ravikiran0606:Adadelta-Optimizer branch from f765fd2 to d9aaa25 Aug 9, 2018

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@lmoneta @stwunsch I updated the methodDL tests with MaxEpochs = 100 as discussed. Can you please re-trigger the build?

@lmoneta

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2018

@phsft-bot build !

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@ravikiran0606

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@lmoneta @stwunsch I guess we are good to merge now 😃

@lmoneta lmoneta merged commit 6c337f5 into root-project:master Aug 9, 2018

2 checks passed

Jenkins CI build Build passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ravikiran0606 ravikiran0606 deleted the ravikiran0606:Adadelta-Optimizer branch Aug 10, 2018

JavierCVilla added a commit to JavierCVilla/root that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.