Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TMVA] Add API Support for Adadelta Optimizer. #2441

Merged
merged 1 commit into from Aug 9, 2018
Merged

[TMVA] Add API Support for Adadelta Optimizer. #2441

merged 1 commit into from Aug 9, 2018

Conversation

ravikiran0606
Copy link
Contributor

  • Implement Adagrad Optimizer.
  • Add Unit tests and MethodDL tests.

Reference Implementation: Tensorflow Adadelta Optimizer

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ravikiran0606 ravikiran0606 changed the title [TMVA] Add API Support for Adadelta Optimizer. [TMVA] [DNM] Add API Support for Adadelta Optimizer. Aug 5, 2018
@ravikiran0606
Copy link
Contributor Author

ravikiran0606 commented Aug 5, 2018 •
edited

@lmoneta @stwunsch Can you please review? And for Adadelta the meanAbsoluteError is of the order of 1e-3. So I would like to discuss on the threshold value for testing the optimizer.

@stwunsch
Copy link
Contributor

stwunsch commented Aug 6, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dimt=ON -Dccache=ON
How to customize builds

@ravikiran0606 ravikiran0606 changed the title [TMVA] [DNM] Add API Support for Adadelta Optimizer. [TMVA] [Do Not Merge] Add API Support for Adadelta Optimizer. Aug 6, 2018
@ashlaban ashlaban mentioned this pull request Aug 7, 2018
Merged
@stwunsch
Copy link
Contributor

stwunsch commented Aug 9, 2018

@ravikiran0606 Can you rebase this PR?

@ravikiran0606 ravikiran0606 changed the title [TMVA] [Do Not Merge] Add API Support for Adadelta Optimizer. [TMVA] Add API Support for Adadelta Optimizer. Aug 9, 2018
@ravikiran0606
Copy link
Contributor Author

@stwunsch @lmoneta I rebased the PR. Can you please trigger the build?

@lmoneta
Copy link
Member

lmoneta commented Aug 9, 2018

@phsft-bot build !

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc48.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on centos7/gcc62.
See console output.

Failing tests:

@lmoneta
Copy link
Member

lmoneta commented Aug 9, 2018

Hi Ravi,
Can you add MaxEpochs=50 or even less in the test to avoid the timeout. We should also understand why the test error continues to decrease

Lorenzo

@phsft-bot
Copy link
Collaborator

Build failed on slc6-i686/gcc49.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on centos7/clang39.
See console output.

Failing tests:

@ravikiran0606
Copy link
Contributor Author

ravikiran0606 commented Aug 9, 2018 •
edited

@lmoneta @stwunsch I updated the methodDL tests with MaxEpochs = 100 as discussed. Can you please re-trigger the build?

@lmoneta
Copy link
Member

lmoneta commented Aug 9, 2018

@phsft-bot build !

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc48, slc6-i686/gcc49, centos7/clang39, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@ravikiran0606
Copy link
Contributor Author

@lmoneta @stwunsch I guess we are good to merge now 😃

@lmoneta lmoneta merged commit 6c337f5 into root-project:master Aug 9, 2018
@ravikiran0606 ravikiran0606 deleted the Adadelta-Optimizer branch August 10, 2018 03:58
JavierCVilla pushed a commit to JavierCVilla/root that referenced this pull request Feb 12, 2019
@ravikiran0606 @JavierCVilla
[TMVA] Add API Support for Adadelta Optimizer. (root-project#2441)
0f4d642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@amadio amadio Awaiting requested review from amadio

Assignees

@lmoneta lmoneta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ravikiran0606 @phsft-bot @stwunsch @lmoneta