Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting a prefix for TMVA weight file (ROOT-8887) #4436

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@lmoneta
Copy link
Member

lmoneta commented Sep 26, 2019

Add a new gConfig.IONames fielf, fWrightFileDIrPrefix.
This allows to have add a prefix for the directory to store the weights.
By default the weights are stored in the directory starting with the dataset name,
e.g. dataset/name0

If a non-nul prefix is set in
TMVA::gConfig().GetIONames().fWeightFileDirPrefix the weights will be stored in weightfile_prefix/dataset_name/weight_file_name

This fixes ROOT-8887
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Sep 26, 2019

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@lmoneta lmoneta force-pushed the lmoneta:fix-tmva-weightdir branch from 543e8f3 to 48d5751 Sep 27, 2019
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Sep 27, 2019

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

1 similar comment
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Build failed on mac1014/cxx17.
See console output.

Errors:

  • FAILED: tmva/tmva/CMakeFiles/TMVA.dir/src/Factory.cxx.o
  • /build/jenkins/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:427:58: error: use of undeclared identifier 'fFileDir'; did you mean 'fileDir'?
  • /build/jenkins/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:445:55: error: use of undeclared identifier 'fFileDir'; did you mean 'fileDir'?
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

  • FAILED: /usr/bin/ccache /usr/bin/c++ -DVECCORE_ENABLE_VC -I/mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/inc -Iinclude -I/mnt/build/workspace/root-pullrequests-build/root/tmva/tmva -I/mnt/build/workspace/root-pullrequests-build/root/tree/treeplayer/inc -I/mnt/build/workspace/root-pullrequests-build/root/graf2d/gpad/inc -I/mnt/build/workspace/root-pullrequests-build/root/graf2d/graf/inc -I/mnt/build/workspace/root-pullrequests-build/root/hist/hist/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/mathcore/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/imt/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/matrix/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/graf3d/g3d/inc -I/mnt/build/workspace/root-pullrequests-build/root/tree/tree/inc -I/mnt/build/workspace/root-pullrequests-build/root/net/net/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/multiproc/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/minuit/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/mlp/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/xml/inc -I/mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/vecops/inc -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -DNDEBUG -fPIC -std=c++11 -MD -MT tmva/tmva/CMakeFiles/TMVA.dir/src/Factory.cxx.o -MF tmva/tmva/CMakeFiles/TMVA.dir/src/Factory.cxx.o.d -o tmva/tmva/CMakeFiles/TMVA.dir/src/Factory.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx
  • /mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:427:57: error: ‘fFileDir’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:445:55: error: ‘fFileDir’ was not declared in this scope
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Build failed on ROOT-fedora27/noimt.
See console output.

Errors:

  • FAILED: tmva/tmva/CMakeFiles/TMVA.dir/src/Factory.cxx.o
  • /mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:427:58: error: ‘fFileDir’ was not declared in this scope
  • /mnt/build/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:445:55: error: ‘fFileDir’ was not declared in this scope
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Errors:

  • /data/sftnight/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:427:58: error: ‘fFileDir’ was not declared in this scope
  • /data/sftnight/workspace/root-pullrequests-build/root/tmva/tmva/src/Factory.cxx:445:55: error: ‘fFileDir’ was not declared in this scope
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Build failed on windows10/default.
See console output.

Errors:

  • C:\build\workspace\root-pullrequests-build\root\tmva\tmva\src\Factory.cxx(427,58): error C2065: 'fFileDir': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tmva\tmva\TMVA.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\tmva\tmva\src\Factory.cxx(445,55): error C2065: 'fFileDir': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tmva\tmva\TMVA.vcxproj]
@lmoneta lmoneta force-pushed the lmoneta:fix-tmva-weightdir branch from 970dc50 to e587208 Oct 4, 2019
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 4, 2019

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

lmoneta added 2 commits Sep 26, 2019
… have add a prefix for the directory to store the weights. By default they are stored in the directory starting with the dataset name.

With the prefix they will be stored in weightfile_prefix/dataset_name/weight_file_name.
This fixes ROOT-8887
@lmoneta lmoneta force-pushed the lmoneta:fix-tmva-weightdir branch from e587208 to 0f487f2 Oct 11, 2019
@phsft-bot

This comment has been minimized.

Copy link
Collaborator

phsft-bot commented Oct 11, 2019

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@lmoneta lmoneta merged commit f1e98c0 into root-project:master Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Jenkins CI build Build finished.
Details
WIP Ready for review
Details
@lmoneta lmoneta deleted the lmoneta:fix-tmva-weightdir branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.