Skip to content

set TBB_PREVIEW_GLOBAL_CONTROL for older tbb versions #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

set TBB_PREVIEW_GLOBAL_CONTROL for older tbb versions #7057

merged 1 commit into from
Jan 18, 2021

Conversation

@xvallspl
Copy link
Contributor

@xvallspl xvallspl commented Jan 18, 2021 •
edited
Loading

tbb::global_control requires to set TBB_PREVIEW_GLOBAL_CONTROL for TBB versions preceding TBB 2019_U4

@xvallspl xvallspl requested a review from eguiraud as a code owner January 18, 2021 10:12
@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@hahnjo
Copy link
Member

hahnjo commented Jan 18, 2021

Still fails to compile core/imt/test/testTBBGlobalControl.cxx on my CentOS 8.

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@xvallspl
Copy link
Contributor Author

xvallspl commented Jan 18, 2021

Still fails to compile core/imt/test/testTBBGlobalControl.cxx on my CentOS 8.

Missed that, thanks!

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@xvallspl xvallspl self-assigned this Jan 18, 2021
@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

hahnjo
hahnjo approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine running CentOS 8 (default TBB 2018.2) and also passes the new test.

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

phsft-bot commented Jan 18, 2021

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@xvallspl xvallspl merged commit 7522e36 into root-project:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo hahnjo approved these changes

@eguiraud eguiraud Awaiting requested review from eguiraud

Assignees

@xvallspl xvallspl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xvallspl @phsft-bot @hahnjo