Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken in PHP 8 due to static return #125

Closed
stefanfisk opened this issue Nov 1, 2021 · 0 comments · Fixed by #126
Closed

Broken in PHP 8 due to static return #125

stefanfisk opened this issue Nov 1, 2021 · 0 comments · Fixed by #126

Comments

@stefanfisk
Copy link
Sponsor Contributor

#122 breaks the project for PHP 7.* due to

acorn/src/Roots/Acorn/Bootloader.php

Line 81 in 59b2322

public static function getInstance(): static

static return type is only available in PHP 8: https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.static.
stefanfisk added a commit to stefanfisk/acorn that referenced this issue Nov 1, 2021
@stefanfisk
Remove static return type
be91362 
Fixes roots#125
@stefanfisk stefanfisk mentioned this issue Nov 1, 2021
Merged
@QWp6t QWp6t closed this as completed in #126 Nov 1, 2021
QWp6t pushed a commit that referenced this issue Nov 1, 2021
@stefanfisk
Remove static return type (#126)
12ccf25 
Fixes #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove static return type stefanfisk/acorn
1 participant
@stefanfisk