Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 deps: bump node to v18 lts #1962

Merged
merged 9 commits into from Jan 18, 2023
Merged

📦 deps: bump node to v18 lts #1962

merged 9 commits into from Jan 18, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Dec 27, 2022

  • bump node to v18 lts

blocked by:

refers:

Type of change

PATCH: backwards compatible change

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

Adds

  • none

Removes

  • none

@github-actions github-actions bot added the CI Continuous integration issue. label Dec 27, 2022
kodiakhq bot pushed a commit that referenced this pull request Jan 17, 2023
squoosh is no longer maintained.

replaces with `sharp` and `svgo`. breaks into three extensions:

- `@roots/bud-imagemin`: responsible for registering the other two. provides facade-like access for common config operations.
- `@roots/bud-imagemin/sharp`: handles managing sharp generators and minimizers
- `@roots/bud-imagemin/svgo`: handles managing svg minimizer

## facades

configure a particular encoder (this basically just calls the appropriate handler for a filetype.. but the signature is identical to the `setEncoderOptions` methods it calls):

```ts
bud.imagemin.encode(`jpeg`, {quality: 90})
```

easily enable lossless quality:

```ts
bud.imagemin.lossless()
```

add a generator:

```ts
bud.imagemin.addPreset(`jpeg`, {
  options: {
    encodeOptions: {
      jpeg: {
        quality: 75
      },
    },
  },
})
```

## New extensions

the child extensions are slightly lower-level.

### bud.imagemin.sharp

- `bud.imagemin.sharp.setEncodeOptions`
- `bud.imagemin.sharp.setGenerator`

### bud.imagemin.svgo

- `bud.imagemin.svgo.setEncodeOptions`
- No generator functionality is provided for svg. It doesn't really make sense.

refers:

- issue #2011
- blocking #1962

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
@kellymears kellymears self-assigned this Jan 18, 2023
@kellymears kellymears added the 🚀! automerge label Jan 18, 2023
@kodiakhq kodiakhq bot merged commit 6729c7a into main Jan 18, 2023
@kodiakhq kodiakhq bot deleted the node-v18 branch January 18, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment