Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add respond.js to Roots distribution #867

Closed
kevinlisota opened this Issue Sep 1, 2013 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

kevinlisota commented Sep 1, 2013

BS3 requires respond.js to work properly with IE8, otherwise the site is always in "mobile" mode. The BS3 base template includes it (and html5shiv): http://getbootstrap.com/getting-started/#template

You've already got html5shiv included in Modernizr, but Modernizr no longer bundles respond.js. Suggest including it in the project and documenting it in Roots, since this is a change for BS3 and IE8 usage is still measurable.

Owner

retlehs commented Sep 8, 2013

i wish that http://core.trac.wordpress.org/ticket/16024 was in wp core.

might just end up adding respond.js to the assets/js/plugins/ folder and have it part of the minified main scripts file, but i'd prefer it to be in assets/js/vendor/ and enqueued with an lt IE9 conditional. could also use modernizr/yepnope to load it...

relevant discussion: http://discourse.roots.io/t/enqueue-respond-script-conditionally-for-ie8-under-grunt/217

Contributor

kevinlisota commented Sep 9, 2013

Probably not a bad idea to put it with the vendor scripts along with their extra files. If you use a CDN for your css, which a number of people do with W3TC/WPEngine/etc, you also need the proxy script & files to make it work.

@retlehs retlehs added feature labels Feb 5, 2014

QCCreative added a commit to QCCreative/roots-with-foundation that referenced this issue Mar 31, 2014

Merged new bower features from roots/7.0.0 branch.
Merge commit '11930de7edc7af1bab3df73e6fe82dc92ddeb5fe' into feature/bower

* commit '11930de7edc7af1bab3df73e6fe82dc92ddeb5fe':
  Ref #867 - Add Respond.js (not enqueued by default)
  Better LESS organization
  Load Modernizr from Bower, lean build with Grunt
  Load jQuery from Bower
  Specific Bootstrap version
  Load Bootstrap via Bower

Conflicts:
	Gruntfile.js
	assets/css/main.min.css
	assets/scss/app.scss
	lib/scripts.php
	package.json

QCCreative added a commit to QCCreative/roots-with-foundation that referenced this issue Mar 31, 2014

Merge branch 'feature/bower' into dev/josh
* feature/bower:
  Ref #867 - Add Respond.js (not enqueued by default)
  Better LESS organization
  Load Modernizr from Bower, lean build with Grunt
  Load jQuery from Bower
  Specific Bootstrap version
  Load Bootstrap via Bower
Owner

retlehs commented Jul 26, 2014

gonna go ahead and close this. even if the wp core ticket gets resolved, i don't think that we need to provide support for lt IE9 out of the box. we do have respond.js included in bower.json, so someone could manually add it to the head template if they'd like to use it

@retlehs retlehs closed this Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment