Simplify/speed up editor style process. #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mce.scss` partial. This cuts styles compiling time in about half. `add_editor_style` now just references `main.css`
|
Just backported this onto one of our in-build Sage sites to see if it works, the Styles compile time immediately dropped from 3.8s to 2.3s (very happy with that, it's a massive site). WP Editor is still working perfectly too. |
|
@chrisatomix great to hear it!!! Thanks for the feedback. |
|
That is what I ended up doing when looking for a way to reduce the assets compile time. |
|
Looks good here |
retlehs
added a commit
that referenced
this pull request
Oct 14, 2015
Simplify/speed up editor style process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #1552.
After playing around, I think the best solution is just to add a
_tinymce.scssfile in/assets/layouts/where we target the tinymce editor and can put conditional styles in there, and then just reference the main.css file in the wp editor.This cuts styles compiling time of the default repo in half (roughly) because we're no longer creating 2 files, and no longer referencing a large scss file and injecting it into another one.