Use better merge method for Webpack Preset config #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `merge.smartStrategy` with `'module.loaders' = 'replace'` to load the preset config allows presets to override the the default webpack config. This is necessary for the coming Tailwind preset which requires `resolve-url-loader` and source maps to be disabled.
This was referenced Jul 18, 2018
|
After further testing, this method doesn't work. 👀 I will look into this... |
|
So this does work, but just not as much as we'd like it to. |
ptrckvzn
added a commit
to ptrckvzn/sage
that referenced
this pull request
Sep 18, 2018
* master: (64 commits) 9.0.5 Update comment [ci skip] Workaround for Bootstrap incompatibility with webpack. Fixes roots#2017 Force `illuminate/support` to `5.6.*` 9.0.3 Revert "Add searchform partial and function to replace default WordPress functionality" Unescape get_language_attributes() Revert "Final filter that renders template should have PHP_INT_MAX priority." $comments_template fix Patreon Final filter that renders template should have PHP_INT_MAX priority. Add data from controller to comments template 9.0.2 Update dependencies Update to Bootstrap 4.1.3 Bump sage-installer Fix Update composer.json UglifyJs: Change the ecma option from 8 to 5 Use smartStrategy to replace loaders with preset (roots#2084) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
merge.smartStrategywith'module.loaders' = 'replace'to load the preset config allows presets to override the the default webpack config. This is necessary for the coming Tailwind preset which requiresresolve-url-loaderand source maps to be disabled.