Author Archives title - WPML Compatibility #999

Merged
merged 1 commit into from Jun 18, 2014

Conversation

Projects
None yet
7 participants
Contributor

ansonkao commented Mar 5, 2014

If WPML String Translation is used to have multilingual author names, this change is needed to persist the translation to the title of the Author Archives page.

Syntax copied from author-template.php in the WordPress codebase.

@ansonkao ansonkao Author Archives title - WPML Compatibility
If WPML String Translation is used to have multilingual author names, this change is needed to persist the translation to the title of the Author Archives page.
b2ca461
Member

QWp6t commented Mar 5, 2014

👍

Member

Foxaii commented Mar 6, 2014

This looks good. Would it be cheeky to ask you to check if any of the other titles have the same issue?

Contributor

ansonkao commented Mar 14, 2014

@Foxaii you might be right that the fix can be extended. The roots_title() isn't used to populate the <head><title>...</title></head>, any reason for the discrepancy?

richpav commented Apr 4, 2014

The Theme Check plugin has a long list of gripes about a Roots base install.

http://pross.org.uk/plugins/theme-check/

Owner

retlehs commented Apr 4, 2014

@richpav not sure how that's related to this pull request, but search issues for theme check — it's been brought up before

Member

JulienMelissas commented Apr 5, 2014

Yeah and if you don't like it don't use it lol

No, but really, Roots isn't meant to be a "use this on 1000 sites" theme, it's a pretty custom deal... It's up to the developer to make it good.

Member

QWp6t commented Apr 5, 2014

totally unrelated but holy crap! i never knew the search function worked for issues! i've always gone through page by page with an explosion of github tabs in my browser manually searching for the right pull request or issue.

so... thanks @retlehs

i am so stupid. 😕

swalkinshaw merged commit eff8b55 into roots:master Jun 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment