Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 18.04 #992

Merged
merged 6 commits into from Dec 12, 2018

Conversation

@swalkinshaw
Copy link
Member

commented May 20, 2018

Adds support for the new Ubuntu 18.04 Bionic LTS release. This also defaults to Bionic in development (via the default Vagrant box).

This change is marked as [BREAKING]. Read below for more details.

Trellis will continue to work on both 16.04 and 18.04. If you want to update Trellis to the latest version but continue using 16.04 Xenial, you'll encounter two minor issues to deal with:

  1. Revert the vagrant_box and vagrant_box_version options in vagrant.default.yml to the 16.04 values you previously had. Or better yet, create a vagrant.local.yml config to override those default values.
  2. You'll see a warning that Trellis is now built for 18.04. You can safely ignore this error message if you want to stay on 16.04.

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch May 20, 2018

roles/mariadb/defaults/main.yml Outdated
@@ -1,6 +1,6 @@
mariadb_keyserver: keyserver.ubuntu.com
mariadb_keyserver: "hkp://keyserver.ubuntu.com:80"

This comment has been minimized.

Copy link
@TangRufus

TangRufus May 20, 2018

Contributor

Why not hkps://?

This comment has been minimized.

Copy link
@swalkinshaw

swalkinshaw May 20, 2018

Author Member

Just copied from Mariadb site but updated to hkps and it works 👍

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch May 20, 2018

@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented May 20, 2018

I'm not sure there's a good seamless upgrade path here. In the past I think we just merged changes like this and people worked around it? The validation definitely makes it harder to deal with though.

If someone is running 16.04 on a server and they pull the latest Trellis updates, they can't really use Trellis at all without modifications or upgrading to 18.04.

@fullyint any thoughts?

@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented May 20, 2018

Turns out that Python 3 is the default on 18.04 which causes problems with Trellis/Ansible right now. Default Trellis behaviour is to let Vagrant install Ansible on the VM (this also applies to Windows usage).

  1. we have validation that prevents Trellis from running on python3.
  2. things may actually be broken until Ansible 2.5+ is required.

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch to 22aebef May 20, 2018

@@ -2,7 +2,7 @@
vagrant_ip: '192.168.50.5'
vagrant_cpus: 1
vagrant_memory: 1024 # in MB
vagrant_box: 'bento/ubuntu-16.04'
vagrant_box: 'bento/ubuntu-18.04'
vagrant_box_version: '>= 201801.02.0'

This comment has been minimized.

Copy link
@TangRufus

TangRufus May 21, 2018

Contributor

Looks like bento/ubuntu-18.04 is first added on 201803.24.0. Do we need to bump vagrant_box_version?

https://github.com/chef/bento/blob/master/CHANGELOG.md

This comment has been minimized.

Copy link
@eshimischi

eshimischi Aug 11, 2018

Already updated to 201807.12.0 (18.04.1 Released)

This comment has been minimized.

Copy link
@swalkinshaw

swalkinshaw Dec 10, 2018

Author Member

I've updated it to the latest 👍

mariadb_keyserver_id: "0xF1656F24C74CD1D8"
mariadb_ppa: "deb [arch=amd64,i386,ppc64el] http://ftp.osuosl.org/pub/mariadb/repo/10.2/ubuntu xenial main"
mariadb_ppa: "deb [arch=amd64] http://nyc2.mirrors.digitalocean.com/mariadb/repo/10.2/ubuntu {{ ansible_distribution_release }} main"

This comment has been minimized.

Copy link
@partounian

partounian Jul 22, 2018

Contributor

👍

@swalkinshaw swalkinshaw referenced this pull request Aug 19, 2018

Closed

Update to ubuntu 18.04.1 LTS #1016

2 of 5 tasks complete
@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

Python 3 support is being worked on in #1031

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch from 22aebef to 2acec4a Dec 3, 2018

@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

Done some updates to this. It should now work with either 16.04 (Xenial) or 18.04 (Bionic) and either Python 2 or 3 so it's quite flexible.

There's only two issues for people wanting to continue with 16.04:

  1. they'll need to update the Vagrant config to switch back to the 16.04 box
  2. they'll see a warning (but not error) that Trellis is built for 18.04 now
@partounian

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

Maybe we should add a little command to run dist upgrades?

@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

@partounian wouldn't this mostly just be running apt-get upgrade? This seems like something that should be run manually because it may need user intervention, or at least for the user to read the output before continuing. Usually for apt installs Trellis just silently agrees and continues on but this could be a dangerous operation.

@partounian

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

@swalkinshaw

sudo apt update 
sudo apt upgrade
sudo apt dist-upgrade
sudo apt autoremove
sudo apt install update-manager-core
sudo do-release-upgrade
@swalkinshaw

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

Ah thanks. But still I'd worry about trying to run all those tasks unattended.

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch 2 times, most recently from b12ad10 to 0f69bfe Dec 5, 2018

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch 2 times, most recently from 4d5391f to 6bd2ece Dec 10, 2018

@swalkinshaw swalkinshaw force-pushed the ubuntu-18.04 branch from 6bd2ece to 28e9850 Dec 12, 2018

@@ -1,6 +1,6 @@
mariadb_keyserver: keyserver.ubuntu.com
mariadb_keyserver: "hkp://keyserver.ubuntu.com:80"

This comment has been minimized.

Copy link
@swalkinshaw

swalkinshaw Dec 12, 2018

Author Member

I switched this back to non-hkps because 16.04 doesn't support it. I'm fine with keeping this "non-secure" version since the official MariaDB instructions use this as well. It makes it way easier for people to stay on 16.04 for now.

@swalkinshaw swalkinshaw merged commit e2a5c95 into master Dec 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@swalkinshaw swalkinshaw deleted the ubuntu-18.04 branch Dec 12, 2018

@retlehs retlehs referenced this pull request Dec 12, 2018

Closed

Revert "Ubuntu 18.04" #1038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.