From 80a58919a2c86eacc6178df5586831383fc8cfcd Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:16:15 -0300 Subject: [PATCH 01/18] Add knapsack gem --- Gemfile | 1 + Gemfile.lock | 3 +++ Rakefile | 2 ++ knapsack_rspec_report.json | 31 +++++++++++++++++++++++++++++++ spec/spec_helper.rb | 3 +++ 5 files changed, 40 insertions(+) create mode 100644 knapsack_rspec_report.json diff --git a/Gemfile b/Gemfile index 72a531a1..88e064cf 100644 --- a/Gemfile +++ b/Gemfile @@ -38,6 +38,7 @@ group :development, :test do gem 'annotate', '~> 3.2', '>= 3.0.3' gem 'dotenv-rails', '~> 2.7.6' gem 'factory_bot_rails', '~> 5.1', '>= 5.1.1' + gem 'knapsack', '~> 4.0.0', '>= 4.0.0' gem 'pry-byebug', '~> 3.9', platform: :mri gem 'pry-rails', '~> 0.3.9' gem 'rspec_api_documentation', '~> 6.1.0' diff --git a/Gemfile.lock b/Gemfile.lock index 46c957a8..76b840a3 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -245,6 +245,8 @@ GEM activerecord kaminari-core (= 1.2.2) kaminari-core (1.2.2) + knapsack (4.0.0) + rake kwalify (0.7.2) launchy (2.5.0) addressable (~> 2.7) @@ -497,6 +499,7 @@ DEPENDENCIES flipper-ui (~> 0.28.0) i18n-tasks (~> 0.9.30) jbuilder (~> 2.10) + knapsack (~> 4.0.0, >= 4.0.0) letter_opener (~> 1.7) listen (~> 3.2) oj (~> 3.9, >= 3.9.2) diff --git a/Rakefile b/Rakefile index e85f9139..ab7fb4ce 100644 --- a/Rakefile +++ b/Rakefile @@ -4,3 +4,5 @@ require_relative 'config/application' Rails.application.load_tasks + +Knapsack.load_tasks if defined?(Knapsack) diff --git a/knapsack_rspec_report.json b/knapsack_rspec_report.json new file mode 100644 index 00000000..76cb2392 --- /dev/null +++ b/knapsack_rspec_report.json @@ -0,0 +1,31 @@ +{ + "spec/requests/api/v1/passwords/edit_spec.rb": 0.18011699999988195, + "spec/requests/api/v1/sessions/destroy_spec.rb": 0.3005360000006476, + "spec/acceptance/settings_spec.rb": 0.16657500000110304, + "spec/routing/registrations_routing_spec.rb": 0.003090999998676125, + "spec/requests/api/v1/users/update_spec.rb": 0.9995309999994788, + "spec/policies/admin_user_policy_spec.rb": 0.01673800000025949, + "spec/requests/api/v1/passwords/create_spec.rb": 0.14932799999951385, + "spec/routing/sessions_routing_spec.rb": 0.0020789999998669373, + "spec/routing/user_routing_spec.rb": 0.0018849999996746192, + "spec/requests/api/v1/passwords/update_spec.rb": 0.44218199999886565, + "spec/acceptance/sessions_spec.rb": 0.5352300000013201, + "spec/requests/api/v1/status_spec.rb": 0.019486999999571708, + "spec/policies/admin/application_policy_spec.rb": 0.009938999999576481, + "spec/acceptance/passwords_spec.rb": 0.6204920000000129, + "spec/policies/admin/user_policy_spec.rb": 0.009479000000283122, + "spec/policies/application_policy_spec.rb": 0.008241999999881955, + "spec/policies/user_policy_spec.rb": 0.015247999999701278, + "spec/requests/api/v1/users/create_spec.rb": 0.4823369999994611, + "spec/policies/admin/page_policy_spec.rb": 0.01077400000031048, + "spec/acceptance/status_spec.rb": 0.009255000000848668, + "spec/acceptance/users_spec.rb": 0.5125680000001012, + "spec/decorators/user_decorator_spec.rb": 0.005363000000215834, + "spec/models/user_spec.rb": 0.05257699999856413, + "spec/requests/api/v1/sessions/create_spec.rb": 0.5477680000003602, + "spec/requests/api/v1/users/show_spec.rb": 0.5338000000010652, + "spec/mailers/application_mailer_spec.rb": 0.0028139999994891696, + "spec/requests/api/v1/feature_flags_spec.rb": 0.04056499999933294, + "spec/policies/admin/admin_user_policy_spec.rb": 0.004445000000487198, + "spec/requests/api/v1/settings_spec.rb": 0.04358700000011595 +} \ No newline at end of file diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index a0cf45ab..10539563 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,10 +4,13 @@ require 'factory_bot_rails' require 'helpers' +require 'knapsack' require 'webmock/rspec' require 'shoulda/matchers' require 'pundit/rspec' +Knapsack::Adapters::RSpecAdapter.bind + FactoryBot.factories.clear FactoryBot.reload From d4672b1bbf9b6c5824611572f840c74c0526616b Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:22:20 -0300 Subject: [PATCH 02/18] Add total nodes to ci workflow --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69920bc6..5d630b4a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,6 +23,8 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} + CI_NODE_TOTAL: 2 + CI_NODE_INDEX: 0 steps: - name: Checkout code From c0f6052488028d30756bb37eba2e0a43e8fbba3d Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:24:53 -0300 Subject: [PATCH 03/18] empty commit to run CI From 62f8ea906f90b5161c817ae8242050ece7b4fd62 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:39:58 -0300 Subject: [PATCH 04/18] empty commit to run CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5d630b4a..d530f988 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: 2 + CI_NODE_TOTAL: 10 CI_NODE_INDEX: 0 steps: From 18f2c6c80a3effcaa4698ab74479fd74e122ce70 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:51:56 -0300 Subject: [PATCH 05/18] empty commit to run CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d530f988..e2e3fba8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: 10 + CI_NODE_TOTAL: 0 CI_NODE_INDEX: 0 steps: From a40547cce9e145e93dfc13ef4f50440a6dae79a8 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 15:59:47 -0300 Subject: [PATCH 06/18] empty commit to run CI --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e2e3fba8..92ada062 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: 0 + CI_NODE_TOTAL: 1 CI_NODE_INDEX: 0 steps: From 691f400b07288c1cf1016a5a021a32bea9e9e1d4 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Thu, 20 Jul 2023 16:25:51 -0300 Subject: [PATCH 07/18] Update CI setup --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92ada062..ddd5de97 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,7 @@ jobs: bundle exec rake code:analysis - name: Run Tests run: | - bundle exec rspec + bundle exec rake knapsack:rspec - name: Check for missing annotations run: bundle exec annotate - name: Check for untracked changes in app and spec directories From 2e624f074dec28f3e6d4d0a0ff49b185a82ab98b Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 1 Aug 2023 09:56:56 -0300 Subject: [PATCH 08/18] Move CI_NODE_TOTAL to secrets --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ddd5de97..498b1a0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: 1 + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} CI_NODE_INDEX: 0 steps: From 27a4dc0c7ad4a7b466b4c1c63543f6c8bee3dae9 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 1 Aug 2023 10:00:03 -0300 Subject: [PATCH 09/18] Move CI_NODE_TOTAL to secrets --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 498b1a0c..5f1a257c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} || "1" CI_NODE_INDEX: 0 steps: From fc2d158eb4e8c68b4f4d39660f843a88119224a3 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 1 Aug 2023 10:06:17 -0300 Subject: [PATCH 10/18] Move CI_NODE_TOTAL to secrets --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5f1a257c..23349081 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} || "1" + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} | "1" CI_NODE_INDEX: 0 steps: From 0ebfcb9a1e31ef2e6d428bd753a0a876ceab24c9 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 1 Aug 2023 10:09:05 -0300 Subject: [PATCH 11/18] Move CI_NODE_TOTAL to secrets --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 23349081..c92afbe1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} | "1" - CI_NODE_INDEX: 0 + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} + CI_NODE_INDEX: 1 steps: - name: Checkout code From 51eb9f87ca8a84671a69254b235cf29ff7b7f56e Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 1 Aug 2023 10:11:02 -0300 Subject: [PATCH 12/18] Move CI_NODE_TOTAL to secrets --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c92afbe1..5e637be3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} - CI_NODE_INDEX: 1 + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} + CI_NODE_INDEX: 0 steps: - name: Checkout code From b685aa8fc57ce3d661fe00065b265768f31f81b0 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 8 Aug 2023 12:24:35 -0300 Subject: [PATCH 13/18] Fix --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5e637be3..ddd5de97 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL }} + CI_NODE_TOTAL: 1 CI_NODE_INDEX: 0 steps: From 57e4b7aaef1c015d19dce6bfcd4d2221727611a0 Mon Sep 17 00:00:00 2001 From: enzofab91 Date: Tue, 8 Aug 2023 16:25:03 -0300 Subject: [PATCH 14/18] Remove advertisements and warning when running CI --- Gemfile | 2 +- Gemfile.lock | 2 +- knapsack_rspec_report.json | 58 +++++++++++++++++++------------------- spec/spec_helper.rb | 2 ++ 4 files changed, 33 insertions(+), 31 deletions(-) diff --git a/Gemfile b/Gemfile index 88e064cf..4c6a26db 100644 --- a/Gemfile +++ b/Gemfile @@ -38,7 +38,7 @@ group :development, :test do gem 'annotate', '~> 3.2', '>= 3.0.3' gem 'dotenv-rails', '~> 2.7.6' gem 'factory_bot_rails', '~> 5.1', '>= 5.1.1' - gem 'knapsack', '~> 4.0.0', '>= 4.0.0' + gem 'knapsack', '~> 4.0.0' gem 'pry-byebug', '~> 3.9', platform: :mri gem 'pry-rails', '~> 0.3.9' gem 'rspec_api_documentation', '~> 6.1.0' diff --git a/Gemfile.lock b/Gemfile.lock index 76b840a3..68d26d56 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -499,7 +499,7 @@ DEPENDENCIES flipper-ui (~> 0.28.0) i18n-tasks (~> 0.9.30) jbuilder (~> 2.10) - knapsack (~> 4.0.0, >= 4.0.0) + knapsack (~> 4.0.0) letter_opener (~> 1.7) listen (~> 3.2) oj (~> 3.9, >= 3.9.2) diff --git a/knapsack_rspec_report.json b/knapsack_rspec_report.json index 76cb2392..4f0d72b1 100644 --- a/knapsack_rspec_report.json +++ b/knapsack_rspec_report.json @@ -1,31 +1,31 @@ { - "spec/requests/api/v1/passwords/edit_spec.rb": 0.18011699999988195, - "spec/requests/api/v1/sessions/destroy_spec.rb": 0.3005360000006476, - "spec/acceptance/settings_spec.rb": 0.16657500000110304, - "spec/routing/registrations_routing_spec.rb": 0.003090999998676125, - "spec/requests/api/v1/users/update_spec.rb": 0.9995309999994788, - "spec/policies/admin_user_policy_spec.rb": 0.01673800000025949, - "spec/requests/api/v1/passwords/create_spec.rb": 0.14932799999951385, - "spec/routing/sessions_routing_spec.rb": 0.0020789999998669373, - "spec/routing/user_routing_spec.rb": 0.0018849999996746192, - "spec/requests/api/v1/passwords/update_spec.rb": 0.44218199999886565, - "spec/acceptance/sessions_spec.rb": 0.5352300000013201, - "spec/requests/api/v1/status_spec.rb": 0.019486999999571708, - "spec/policies/admin/application_policy_spec.rb": 0.009938999999576481, - "spec/acceptance/passwords_spec.rb": 0.6204920000000129, - "spec/policies/admin/user_policy_spec.rb": 0.009479000000283122, - "spec/policies/application_policy_spec.rb": 0.008241999999881955, - "spec/policies/user_policy_spec.rb": 0.015247999999701278, - "spec/requests/api/v1/users/create_spec.rb": 0.4823369999994611, - "spec/policies/admin/page_policy_spec.rb": 0.01077400000031048, - "spec/acceptance/status_spec.rb": 0.009255000000848668, - "spec/acceptance/users_spec.rb": 0.5125680000001012, - "spec/decorators/user_decorator_spec.rb": 0.005363000000215834, - "spec/models/user_spec.rb": 0.05257699999856413, - "spec/requests/api/v1/sessions/create_spec.rb": 0.5477680000003602, - "spec/requests/api/v1/users/show_spec.rb": 0.5338000000010652, - "spec/mailers/application_mailer_spec.rb": 0.0028139999994891696, - "spec/requests/api/v1/feature_flags_spec.rb": 0.04056499999933294, - "spec/policies/admin/admin_user_policy_spec.rb": 0.004445000000487198, - "spec/requests/api/v1/settings_spec.rb": 0.04358700000011595 + "spec/policies/admin/page_policy_spec.rb": 0.038240999972913414, + "spec/routing/sessions_routing_spec.rb": 0.006703999999444932, + "spec/requests/api/v1/users/create_spec.rb": 0.5093869999982417, + "spec/acceptance/settings_spec.rb": 0.17437299998709932, + "spec/acceptance/sessions_spec.rb": 0.5090029999846593, + "spec/acceptance/status_spec.rb": 0.009465000010095537, + "spec/requests/api/v1/sessions/destroy_spec.rb": 0.2923869999940507, + "spec/policies/admin/user_policy_spec.rb": 0.020087999990209937, + "spec/routing/registrations_routing_spec.rb": 0.001361000002361834, + "spec/policies/admin/application_policy_spec.rb": 0.011096000031102449, + "spec/policies/admin_user_policy_spec.rb": 0.009194999991450459, + "spec/routing/user_routing_spec.rb": 0.0026309999520890415, + "spec/requests/api/v1/passwords/update_spec.rb": 0.4883949999930337, + "spec/requests/api/v1/feature_flags_spec.rb": 0.040616000012960285, + "spec/requests/api/v1/settings_spec.rb": 0.0425929999910295, + "spec/requests/api/v1/passwords/create_spec.rb": 0.15221400000154972, + "spec/acceptance/users_spec.rb": 0.5729850000352599, + "spec/policies/user_policy_spec.rb": 0.015309000038541853, + "spec/requests/api/v1/users/update_spec.rb": 0.9842829999979585, + "spec/requests/api/v1/status_spec.rb": 0.01666500000283122, + "spec/policies/application_policy_spec.rb": 0.008917000028304756, + "spec/policies/admin/admin_user_policy_spec.rb": 0.005394000036176294, + "spec/requests/api/v1/sessions/create_spec.rb": 0.49404099996900186, + "spec/decorators/user_decorator_spec.rb": 0.005971000005956739, + "spec/requests/api/v1/passwords/edit_spec.rb": 0.08089700003620237, + "spec/acceptance/passwords_spec.rb": 0.6197870000032708, + "spec/models/user_spec.rb": 0.09392800001660362, + "spec/mailers/application_mailer_spec.rb": 0.0020680000307038426, + "spec/requests/api/v1/users/show_spec.rb": 0.5047900000354275 } \ No newline at end of file diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 10539563..195c9cdb 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,6 +9,8 @@ require 'shoulda/matchers' require 'pundit/rspec' +Knapsack.tracker.config(enable_time_offset_warning: false) + Knapsack::Adapters::RSpecAdapter.bind FactoryBot.factories.clear From 316918a121e5fd48db07a4f30787d833bad1fdb9 Mon Sep 17 00:00:00 2001 From: Rodrigo Eizmendi Date: Thu, 10 Aug 2023 12:10:06 -0300 Subject: [PATCH 15/18] move harcoded values to secrets with a default value --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ddd5de97..d331f8fc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: 1 - CI_NODE_INDEX: 0 + CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL || 1 }} + CI_NODE_INDEX: ${{ secrets.CI_NODE_INDEX || 0 }} steps: - name: Checkout code From bda5acaa2a02dfa25b680fe6307dbad84b825a0c Mon Sep 17 00:00:00 2001 From: Rodrigo Eizmendi Date: Fri, 11 Aug 2023 15:32:31 -0300 Subject: [PATCH 16/18] try to set matrix strategy --- .github/workflows/ci.yml | 17 +++++++++++++++-- knapsack_rspec_report.json | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d331f8fc..853ee7ef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,11 +20,20 @@ jobs: --health-timeout 5s --health-retries 5 + strategy: + fail-fast: false + matrix: + # Set N number of parallel jobs you want to run tests on. + # Use higher number if you have slow tests to split them on more parallel jobs. + # Remember to update ci_node_index below to 0..N-1 + ci_node_total: [4] + # set N-1 indexes for parallel jobs + # When you run 2 parallel jobs then first job will have index 0, the second job will have index 1 etc + ci_node_index: [0, 1, 2, 3] + env: RAILS_ENV: test CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }} - CI_NODE_TOTAL: ${{ secrets.CI_NODE_TOTAL || 1 }} - CI_NODE_INDEX: ${{ secrets.CI_NODE_INDEX || 0 }} steps: - name: Checkout code @@ -52,6 +61,10 @@ jobs: run: | bundle exec rake code:analysis - name: Run Tests + env: + KNAPSACK_CI_NODE_TOTAL: ${{ matrix.ci_node_total }} + KNAPSACK_CI_NODE_INDEX: ${{ matrix.ci_node_index }} + KNAPSACK_PRO_LOG_LEVEL: info run: | bundle exec rake knapsack:rspec - name: Check for missing annotations diff --git a/knapsack_rspec_report.json b/knapsack_rspec_report.json index 4f0d72b1..cde01527 100644 --- a/knapsack_rspec_report.json +++ b/knapsack_rspec_report.json @@ -28,4 +28,4 @@ "spec/models/user_spec.rb": 0.09392800001660362, "spec/mailers/application_mailer_spec.rb": 0.0020680000307038426, "spec/requests/api/v1/users/show_spec.rb": 0.5047900000354275 -} \ No newline at end of file +} From fa62ac798b8d284171989c21bfcfe9d57716a0be Mon Sep 17 00:00:00 2001 From: Rodrigo Eizmendi Date: Fri, 11 Aug 2023 15:59:44 -0300 Subject: [PATCH 17/18] queue mode works? --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 853ee7ef..10339e96 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -64,9 +64,10 @@ jobs: env: KNAPSACK_CI_NODE_TOTAL: ${{ matrix.ci_node_total }} KNAPSACK_CI_NODE_INDEX: ${{ matrix.ci_node_index }} - KNAPSACK_PRO_LOG_LEVEL: info + KNAPSACK_FIXED_QUEUE_SPLIT: true + KNAPSACK_LOG_LEVEL: info run: | - bundle exec rake knapsack:rspec + bundle exec rake knapsack:queue:rspec - name: Check for missing annotations run: bundle exec annotate - name: Check for untracked changes in app and spec directories From 8b6591e67013e06cdc819162a58458285c9f231e Mon Sep 17 00:00:00 2001 From: Rodrigo Eizmendi Date: Fri, 11 Aug 2023 16:14:10 -0300 Subject: [PATCH 18/18] vars --- .github/workflows/ci.yml | 7 +++---- spec/spec_helper.rb | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 10339e96..77510ddf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,12 +62,11 @@ jobs: bundle exec rake code:analysis - name: Run Tests env: - KNAPSACK_CI_NODE_TOTAL: ${{ matrix.ci_node_total }} - KNAPSACK_CI_NODE_INDEX: ${{ matrix.ci_node_index }} - KNAPSACK_FIXED_QUEUE_SPLIT: true + CI_NODE_TOTAL: ${{ matrix.ci_node_total }} + CI_NODE_INDEX: ${{ matrix.ci_node_index }} KNAPSACK_LOG_LEVEL: info run: | - bundle exec rake knapsack:queue:rspec + bundle exec rake knapsack:rspec - name: Check for missing annotations run: bundle exec annotate - name: Check for untracked changes in app and spec directories diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 195c9cdb..26d70c98 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,7 +10,6 @@ require 'pundit/rspec' Knapsack.tracker.config(enable_time_offset_warning: false) - Knapsack::Adapters::RSpecAdapter.bind FactoryBot.factories.clear