Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New check for vignettes #45

Closed
mpadge opened this issue Sep 10, 2021 · 1 comment · Fixed by #49
Closed

New check for vignettes #45

mpadge opened this issue Sep 10, 2021 · 1 comment · Fixed by #49
Assignees

Comments

@mpadge
Copy link
Member

mpadge commented Sep 10, 2021

Because Dev Guide clearly requires them, as discussed in this software-review-meta issue (link thanks to @maelle ).

@maelle maelle self-assigned this Sep 10, 2021
@mpadge
Copy link
Member Author

mpadge commented Sep 10, 2021

@maelle This should even be somewhat easier because the information is already there:

num_vignettes = unname (s$vignettes [1]),

That then forms the start of the main list here

pkgcheck/R/pkgcheck-fn.R

Lines 15 to 16 in a4eb980

s <- pkgstats_checks (path)
out <- s$out

And within that function there's this:

out$summary <- pkgchk_pkgstats_summary (s)

which collates the list of numbers of objects including vignettes. Admittedly kinda convoluted like that, but at least the data are already there, and you can just do vignette steps 4-6, and not worry about 1-3. The value you need for those is then checks$summary$num_vignettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants