Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process is perhaps too verbose. #50

Closed
gfinak opened this issue Sep 6, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@gfinak
Copy link
Member

commented Sep 6, 2018

Now that the package is mature, perhaps the build process echoing messages to the console could be made less verbose, while still logging everything to file.
Major warnings and errors should still be echoed to console, but the more minor information only messages could be pared down.

@gfinak gfinak added the enhancement label Sep 6, 2018

gfinak added a commit that referenced this issue Sep 6, 2018

Reduce the console output from logging and
create a new logger that logs at different thresholds to console and to file. #50
Update tests. Update codemeta.json

gfinak added a commit that referenced this issue Sep 7, 2018

call proj_set conditionally when making vignettes.
Keeps things quiet on the console.
#50

gfinak added a commit that referenced this issue Sep 7, 2018

Improve logging.
Improve console messages.
#50 and #51
@gfinak

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

  • Tidied up build output.
  • Verbose output written to log file, but brief output to console.
  • knitr output it silenced.
  • messages are now consistently using the done() interface.

image

@gfinak gfinak closed this Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.