Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_gsod returns additional station data #49

Closed
EFreiberger opened this issue Jan 16, 2019 · 3 comments
Closed

get_gsod returns additional station data #49

EFreiberger opened this issue Jan 16, 2019 · 3 comments
Assignees
Labels
bug

Comments

@EFreiberger
Copy link

@EFreiberger EFreiberger commented Jan 16, 2019

I tried to download data from 2 stations with this piece of code

install.packages("GSODR")
library(GSODR)
library(dplyr)

load(system.file("extdata", "country_list.rda", package = "GSODR"))
load(system.file("extdata", "isd_history.rda", package = "GSODR"))

a <- get_GSOD(years = 2010, station = "489300-99999")    
b <- get_GSOD(years = 2010, station = "489260-99999")

I don't understand why b contains data from a:

image

I used package version 1.3.1 and R version 3.5.0.

Many thanks for your help!

@adamhsparks adamhsparks added the bug label Jan 17, 2019
@adamhsparks adamhsparks self-assigned this Jan 17, 2019
@adamhsparks
Copy link
Member

@adamhsparks adamhsparks commented Jan 17, 2019

Ah, hmm. I have an idea what's going on, but I don't know how or why.

Thanks for alerting me to this.

@adamhsparks
Copy link
Member

@adamhsparks adamhsparks commented Jan 17, 2019

Found it. Fixed it.

5dcf944

I'll try to get a new release on CRAN in the next few days. Tomorrow I'll update the master branch here on GitHub.

Thanks for reporting.

@adamhsparks
Copy link
Member

@adamhsparks adamhsparks commented Jan 19, 2019

Closed with release of 1.3.2 on CRAN. https://github.com/ropensci/GSODR/releases/tag/1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.