Skip to content

/ codemetar

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate encoding issues from CITATION parsing #44

Closed
cboettig opened this issue Dec 15, 2017 · 3 comments
Closed

investigate encoding issues from CITATION parsing #44

cboettig opened this issue Dec 15, 2017 · 3 comments

Comments

@cboettig
Copy link
Member

@cboettig cboettig commented Dec 15, 2017

ropensci/osmdata#109
@mpadge
Copy link
Member

@mpadge mpadge commented Jan 24, 2018

any further insights here @cboettig? nudge, nudge
@cboettig cboettig closed this in 2246fba Jan 25, 2018
@cboettig
Copy link
Member Author

@cboettig cboettig commented Jan 25, 2018

@mpadge Thanks for the nudge. Apparently utils::parseCitation wants to use whatever encoding is declared in the DESCRIPTION file, if given. In wrapping that I wasn't passing parseCitation the optional DESCRIPTION meta. Commit above should fix this.
@mpadge
Copy link
Member

@mpadge mpadge commented Jan 25, 2018

Great @cboettig, thanks! An easy fix after all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@cboettig @mpadge
You can’t perform that action at this time.