Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience: Allow start/end to be given as year-integers #10

Closed
zauster opened this issue Jan 29, 2018 · 2 comments
Closed

Convenience: Allow start/end to be given as year-integers #10

zauster opened this issue Jan 29, 2018 · 2 comments

Comments

@zauster
Copy link

@zauster zauster commented Jan 29, 2018

Hey,

i use always annual data (and it's also the default value). So it would be convenient to let the user specify only start = 2005 or end = 2005 if freq = "annual". start = 2005 would expand to 2005-01-01 and end = 2005 to 2005-12-31.
What do you think of that?

@ChrisMuir
Copy link
Member

@ChrisMuir ChrisMuir commented Jan 30, 2018

I like this idea, thanks for the suggestion! I may have some time this week to do this, otherwise this weekend.

Thanks again!

ChrisMuir added a commit that referenced this issue Feb 4, 2018
@ChrisMuir
Copy link
Member

@ChrisMuir ChrisMuir commented Feb 4, 2018

Just pushed this feature.

Now, when arg freq is set to "annual", these inputs for both start_date and end_date would all be valid: "2016-01-01", "2016", and 2016.

When arg freq is set to "monthly", these inputs for bot start_date and end_date would all be valid: "2016-01-01" and "2016-01".

Thanks again for suggesting this feature @zauster!

ChrisMuir added a commit that referenced this issue Feb 4, 2018
@ChrisMuir ChrisMuir closed this Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.