Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a retry method to HttpClient #95

Merged
merged 7 commits into from
Dec 5, 2018
Merged

Adds a retry method to HttpClient #95

merged 7 commits into from
Dec 5, 2018

Commits on Dec 3, 2018

  1. Adds a retry method to HttpClient 

    The parameters for retry are modeled after httr::RETRY(), and the wait
time is calculated according to the same algorithm (exponential backoff
with full jitter). It also uses the same defaults.
    @hlapp
    hlapp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    6aa2a07 View commit details
    Browse the repository at this point in the history

  2. Adds tests for HttpClient

    @hlapp
    hlapp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    7ed078e View commit details
    Browse the repository at this point in the history

  3. Isolates the rest of the tests from mock testing

    @hlapp
    hlapp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    e4c8bd7 View commit details
    Browse the repository at this point in the history

  4. Fixes issue of dangling connections from async request errors

    @hlapp
    hlapp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    fdcafbf View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Removes possibilities for open connections ending up dangling 

    Further addresses #93. Not clear whether this closes all such possibilities
because I cannot reproduce the issue reported on Travis for "R: devel",
and the dangling connections reported at the end of running devtools::test()
disappeared already after fdcafbf.
    @hlapp
    hlapp committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    c159bba View commit details
    Browse the repository at this point in the history

  2. Adds a callback method to method retry

    @hlapp
    hlapp committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    3b9de8b View commit details
    Browse the repository at this point in the history

  3. Makes retry for ratelimit reset test a little more robust

    @hlapp
    hlapp committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1498327 View commit details
    Browse the repository at this point in the history