Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadditional validation errors #48
Comments
|
Fixes checked in PR #49 . |
|
Closed by #49 Please let me know if now would be a good time to prepare a CRAN release for these changes? Or shall we hold tight and see if there's any remaining validation issues we can squash first? @mbjones would you be willing to send another PR with updates to NEWS.md describing the validator changes? Also, the DESCRIPTION author list is now out of date -- may I add you and @amoeba as co-authors there? |
|
I think another release now would be good -- those were serious errors and we should get them out into the community so that there's less confusion over correct validation. I'll send another PR and update both files, and I'll bump the version to 0.4.0 in DESCRIPTION. Do you want to run |
|
Thanks! Feel free either way on the |
I found additional validation errors in addition to #46.
packageIdis not used as an identifier for checking uniqueness with otheridvalues and for resolving references.annotationelements inadditionalMetadatabecause their parent doesn't contain anid. This should be ok, because inadditionalMetadatathe annotation subject is determined via thedescribesfields.annotation/@referencesattribute values are not checked during validation to be sure they resolve to anid-- only the//referenceselements are checked.I've begun implementing fixes for these in my fork here: https://github.com/mbjones/emld/tree/46-validation-errors