Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits made in response to rOpenSci review #30

Merged
merged 4 commits into from Feb 5, 2019
Merged

Edits made in response to rOpenSci review #30

merged 4 commits into from Feb 5, 2019

Conversation

@cboettig
Copy link
Member

@cboettig cboettig commented Jan 26, 2019

Addresses the issues raised by @khondula (see #28 for details) and @gothub (see #29 for details) rOpenSci Software Review; ropensci/software-review#269

cboettig added 4 commits Jan 24, 2019
closes #28, #29
@cboettig cboettig mentioned this pull request Jan 26, 2019
14 of 19 tasks complete
@cboettig
Copy link
Member Author

@cboettig cboettig commented Feb 5, 2019

closes #28 & #29

@cboettig cboettig merged commit 9f2bbc8 into master Feb 5, 2019
6 checks passed
6 checks passed
codecov/patch Coverage not affected when comparing 92b70ee...13ee1d6
Details
codecov/project 88.27% remains the same compared to 92b70ee
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@cboettig cboettig deleted the ropensci-review branch Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.