Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRelax stmml XPaths when validating custom units #35
Conversation
Hard-coding these namespace prefix names in the affected XPaths is too brittle because prefix names are not guaranteed to always be 'stmml' even in valid documents. Fixes #34
cboettig
merged commit 8ec1959
into
ropensci:master
4 checks passed
4 checks passed
codecov/project
Absolute coverage decreased by -0.16% but relative coverage increased by +11.72% compared to 27c2c36
Details
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hard-coding these namespace prefix names in the affected XPaths is too
brittle because prefix names are not guaranteed to always be 'stmml'
even in valid documents.
Fixes #34