Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package to reflect new 2.2.0 namespace #40

Merged
merged 8 commits into from Oct 10, 2019

Conversation

@amoeba
Copy link
Contributor

@amoeba amoeba commented Oct 10, 2019

Between the last sync and the final 2.2.0 release, we:

  • Changed the EML namespace from eml://eml.ecoinformatics.org/eml-2.2.0 to https://eml.ecoinformatics.org/eml-2.2.0 to move forward with a more standard namespace scheme since everyone minting their own custom schemes never took off and we centralized around HTTP(S).
  • Added a few attributes to the annotation element

This PR basically:

  • Updates XSDs to match 2.2.0 released versions of them
  • Switches the default schema version to 2.2.0
  • Updates all test docs to the new namespace
  • Factors out previously-hardcoded references to eml://... to be dynamic based up on version, using the new https://... prefix when appropriate.

Other stuff I ended up doing:

  • Fixing breakage in test.sh caused by jq
  • Rebuilding pkgdown site

Could use a quick sanity check as it's quite a lot of change.

Closes #39.

amoeba added 8 commits Sep 27, 2019
Per #39, EML's final schema URI space now begins with https://eml.ecoinformatics.org/{module}-{version} instead of eml:// like in the past.

Both EML and STMML namespaces were updated for EML 2.2.0 docs (STMML gets updated because EML 2 uses STML 1.2)
This adds a custom Dockerfile based on rocker/verse that lets jqr be installed in the container so the tests pass. Couple of other minor tweaks to clean related things up.
@amoeba amoeba mentioned this pull request Oct 10, 2019
@cboettig
Copy link
Member

@cboettig cboettig commented Oct 10, 2019

Thanks for cranking through this - yeah this one must have been a bit of a beast to change with so many places that namespace is hardwired in test and example files. I've skimmed through all the changes and looks good! (some whitespace trimming makes them look even more sweeping than they really are, but oh well).

Only thing -- I don't think you created an entry in NEWS.md describing this change yet? Can you bump the package version to 0.2.1 and add an entry about the changed namespace? I guess this is technically a breaking change, and maybe it should be more of a major version bump -- though calling this 1.0.0 seems a bit weird -- I don't fully buy into semantic versioning since any change can break something for someone... What do you think?

Also, is this a good point to cut a new release to CRAN or can you think of any other things we might want to tackle in the near-term first?

@cboettig cboettig merged commit a15b477 into ropensci:master Oct 10, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 72.72% of diff hit (target 88.11%)
Details
codecov/project 88.11% remains the same compared to 8ea4420
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeanetteclark
Copy link
Contributor

@jeanetteclark jeanetteclark commented Oct 10, 2019

Thanks for this @amoeba.

Before cutting the new release, we might want to switch back to setting the default EML version to 2.2.0 now that this is officially out. I created an issue requesting the switch to 2.1.1 until 2.2.0 got released.

@cboettig cboettig mentioned this pull request Oct 10, 2019
3 of 3 tasks complete
@cboettig
Copy link
Member

@cboettig cboettig commented Oct 10, 2019

p.s. @amoeba Just for reference, ropensci's docs server builds pkgdown automatically now as part of the nightly checks, so no need to build it locally. Should probably drop it from the repo here.

See https://docs.ropensci.org/emld/ for the auto-generated docs and http://packages.ropensci.org/job/emld/ for the Jenkins job log that creates these.

All 🎩 work from @jeroen 😄

@amoeba
Copy link
Contributor Author

@amoeba amoeba commented Oct 10, 2019

Slick, nice work @jeroen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.