Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadditional validation errors fixed #49
Conversation
Annotations in additionalMetadata are attached to their subjects via the `describes` element, and so we so not need to throw a validation error if an annotation parent contains an id or has an ancestor of additionalMetadate with a describes child.
The attributes were incorrectly being added as element children, and now are back to attributes.
Adds the '//annotation[@references]' values to the list to be resolved.
|
Thanks @mbjones . This looks good to me. Yeah, I think the manual edits to the eml-2.2.0.json is a reasonable way to go at this stage. The R script for generating that is a bit out of step anyway -- I had started switching it over to the tabular form, which doesn't right now seem to be indicating attribute vs element status anyway and probably should be done on a branch. I do at some point still harbor hopes of improving the schema parsing so that we can generate better first-class functions automatically (see https://github.com/cboettig/build.eml), but given that the parsing is imperfect fixing the |
Fixes the 3 validation errors described in #48.
This set of changes relies on a change to the json file in data-raw that was manually modified. So we should discuss whether there is a parsing error as well that needs to be fixed in parsing the eml schema documents.