Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond differently to status code classes #12

Closed
sckott opened this issue Apr 12, 2018 · 2 comments
Closed

Respond differently to status code classes #12

sckott opened this issue Apr 12, 2018 · 2 comments
Milestone

Comments

@sckott
Copy link
Owner

sckott commented Apr 12, 2018

from @maelle

Maybe we should respond differently to different HTTP status code classes.

Change default type of response:

  • 1xx-3xx: message (only a message is given, so no stoppage of code execution by default)
  • 4xx-5xx: stop (definitely an error, so we'll stop with error message) (use can also choose warning)

Muffling on a http() call (optionally don't respond at all):

  • 1xx-3xx: if muffle=TRUE, return http response class invisibly
  • 4xx-5xx: if muffle=TRUE, it's ignored since there was an error

that is, muffling only applies to 1xx-3xx statuses

@sckott sckott added this to the v0.5 milestone Apr 12, 2018
sckott added a commit that referenced this issue Apr 12, 2018
still need to work on the R6 methods specfiic to each http code
@sckott sckott closed this as completed Apr 9, 2020
@maelle
Copy link
Collaborator

maelle commented Apr 10, 2020

TIL the word "muffling" 😁

@sckott
Copy link
Owner Author

sckott commented Apr 10, 2020

ah, i didn't think about whether people might find that word confusing, should have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants