Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change S4 classes to S3 #312

Closed
25 tasks done
stewid opened this issue Jan 14, 2018 · 3 comments
Closed
25 tasks done

[WIP] Change S4 classes to S3 #312

stewid opened this issue Jan 14, 2018 · 3 comments

Comments

@stewid
Copy link
Member

stewid commented Jan 14, 2018

  • cred_env
  • cred_ssh_key
  • cred_token
  • cred_user_pass
  • git_blame
  • git_blame_hunk
  • git_blob
  • git_branch
  • git_commit
  • git_diff
  • git_diff_file
  • git_diff_hunk
  • git_diff_line
  • git_fetch_head
  • git_merge_result
  • git_note
  • git_reference
  • git_reflog_entry
  • git_repository
  • git_signature
  • git_stash
  • git_tag
  • git_time
  • git_transfer_progress
  • git_tree
@jdblischak
Copy link
Contributor

What's the timeline for releasing this new version to CRAN? The change from S4 to S3 is going to break my projects that rely on git2r.

jdblischak added a commit to workflowr/workflowr that referenced this issue Feb 12, 2018
git2r is changing the methods and classes from S4 to S3.

ropensci/git2r#312
@stewid
Copy link
Member Author

stewid commented Feb 14, 2018

At the moment, I don't know. I'm waiting for the next release of libgit2 (version 0.27).

@jdblischak
Copy link
Contributor

OK. For now I've pinned my package to depend on git2r <= 0.21.0. Please do let me know if you'd like me to test anything out as you make this upgrade. Thanks for all your hard work on this very useful package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants