New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with SSH on Windows #327
Comments
|
@ijlyttle Thanks for reporting this. @jeroen I think an updated version of libssh2 is needed to fix this, could you please update to 1.8 on https://github.com/rwinlib/libssh2 |
Update libssh2 on Windows and cleanup build. Fixes #327
|
OK. @ijlyttle can you try the dev version? Make sure devtools::install_github("ropensci/git2r") |
|
I have tested the dev version on MacOS and Windows - Mac seems to be OK. However, on Windows: I don't even get to the point where I am asked for my ssh passphrase, so I suspect there is something else going on here. |
|
Was this issue caused by the upgrade of libgit2, or was it maybe not working before either? |
|
I suspect it was not working before. |
|
Could you open a new issue for this to make sure these problems do not get mixed up? |
|
Thanks @jeroen I'm currently changing from S4 classes to S3 in the 'master' branch and I'm not ready to submit it to CRAN yet. I have therefore cherry-picked the fix to the Unfortunatly, I get the following error on winbuilder which I think is also caused by the recent change on GitHub. @jeroen do you think that is the reason? |
|
Yes it's because of https://twitter.com/opencpu/status/966785019560775685 Hopefully winbuilder will be updated soon. |
|
FYI the win builder is fixed now. |
Hi,
A colleague and I noticed this behavior on Windows, using the CRAN version of git2r:
This used to work for me, but now it does not.
My colleague pointed out this recent notice from GitHub:
https://github.com/blog/2507-weak-cryptographic-standards-removed
We also came across people having a similar problem in git-up/GitUp#241
The commonality between the two seems to be the use of libssh2. I'm afraid that this is as far as we have been able to dig.
It looks like you may be addressing this already in #325 - if this is the case, please accept my apologies and close this issue.
I can be of help to test solutions, but I don't think I have the skills to implement a solution.
Thanks!
The text was updated successfully, but these errors were encountered: