Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i25: Allow validation of a subset of the data #27

Merged
merged 3 commits into from Aug 22, 2019

Conversation

@richfitz
Copy link
Member

commented Aug 22, 2019

The inverse of the features in #19, this PR will allow the data to be subsetted before validation.

Ideally this would allow either jsonpath or similar (or json pointer as for $ref) but that can be added later.

@richfitz richfitz requested a review from r-ash Aug 22, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         172    181    +9     
=====================================
+ Hits          172    181    +9
Impacted Files Coverage Δ
R/validate.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a6a2b...b41f53d. Read the comment docs.

@r-ash
r-ash approved these changes Aug 22, 2019
Copy link
Collaborator

left a comment

Looks great too. Super tidy PR.

@r-ash r-ash merged commit 9cc5c87 into master Aug 22, 2019

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 80a6a2b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.