New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb additions to add / complete all methods #27
Conversation
thanks - this PR needs some conflict fixing - then i'll take a look |
Thanks, conflicts are now resolved, were related to changes on another branch that git could not auto-merge. |
thanks, having a look |
Sorry for delay in looking at this, was on vacation. Looks okay to me, but I'll see if @jeroen can have a look as he is much more familiar than I with mongodb. |
Looks good to me. Some comments: The create eg no longer works with this PR src <- src_mongo()
docdb_create(src, key = "mtcars", value = mtcars)
#> Parameter 'key' is different from parameter 'collection', was given as test in src_mongo(). I realize it's intended behavior, but should change the example to have a working eg. Actually, all the mongo examples and tests have this problem where the Maybe i'm not understanding this change - seems like with this PR you can only have one collection and only one key in that collection of the same name. Is that correct? If so, what's the reason for that? |
…on in src_mongo() is not the same as in db_*() calls
thanks - I'll have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure egs work
Hi, this is a PR for the mongodb implementation in the package. It completes the set of methods for
src_mongo()
. Also, it extends already existing functions to plausible and important use cases, e.g. for selectively deleting and updating documents. All changes respect the principles I am aware of for thenodbi
package (e.g. using data frames as input, harmonisation of outputs and inputs across connectors). I wish to use thenodbi
package in my project ctrdata, where in a local branchsrc_mongo()
andsrc_sqlite()
(PR #25) already work interchangeably. Many thanks for reviewing and considering!