uncomment handle errors test, see what travis does, #52

ropensci · Jan 9, 2018 · 03f5096 · 03f5096
1 parent 99f7358
commit 03f5096
Showing 1 changed file with 52 additions and 52 deletions.
diff --git a/tests/testthat/test-handle_errors.R b/tests/testthat/test-handle_errors.R
@@ -21,72 +21,72 @@ gnp <- function(u) {
 }
 
 
-# test_that("badArgument is triggered", {
-#   skip_on_cran()
+test_that("badArgument is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$badArgument)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "badArgument" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$badArgument)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "badArgument" %in% attr(er, "error_codes")))
+} )
 
 
-# test_that("badResumptionToken is triggered", {
-#   skip_on_cran()
+test_that("badResumptionToken is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$badResumptionToken)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "badResumptionToken" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$badResumptionToken)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "badResumptionToken" %in% attr(er, "error_codes")))
+} )
 
-# test_that("badVerb is triggered", {
-#   skip_on_cran()
+test_that("badVerb is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$badVerb)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "badVerb" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$badVerb)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "badVerb" %in% attr(er, "error_codes")))
+} )
 
-# test_that("cannotDisseminateFormat is triggered", {
-#   skip_on_cran()
+test_that("cannotDisseminateFormat is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$cannotDisseminateFormat)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "cannotDisseminateFormat" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$cannotDisseminateFormat)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "cannotDisseminateFormat" %in% attr(er, "error_codes")))
+} )
 
-# test_that("idDoesNotExist is triggered", {
-#   skip_on_cran()
+test_that("idDoesNotExist is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$idDoesNotExist)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "idDoesNotExist" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$idDoesNotExist)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "idDoesNotExist" %in% attr(er, "error_codes")))
+} )
 
-# test_that("noRecordsMatch is triggered", {
-#   skip_on_cran()
+test_that("noRecordsMatch is triggered", {
+  skip_on_cran()
 
-#   xml <- gnp(error_url$noRecordsMatch)
-#   expect_error( handle_errors(xml) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#   expect_true( tryCatch( handle_errors(xml), error=function(er) "noRecordsMatch" %in% attr(er, "error_codes")))
-# } )
+  xml <- gnp(error_url$noRecordsMatch)
+  expect_error( handle_errors(xml) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+  expect_true( tryCatch( handle_errors(xml), error=function(er) "noRecordsMatch" %in% attr(er, "error_codes")))
+} )
 
 
-# test_that("noSetHierarchy is triggered", {
-#   skip_on_cran()
+test_that("noSetHierarchy is triggered", {
+  skip_on_cran()
 
-#   if (!is.null(error_url$noSetHierarchy)) {
-#     xml <- gnp(error_url$noSetHierarchy)
-#     expect_error( handle_errors(xml) )
-#     expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
-#     expect_true( tryCatch( handle_errors(xml), error=function(er) "noSetHierarchy" %in% attr(er, "error_codes")))
-#   }
+  if (!is.null(error_url$noSetHierarchy)) {
+    xml <- gnp(error_url$noSetHierarchy)
+    expect_error( handle_errors(xml) )
+    expect_true( tryCatch( handle_errors(xml), error=function(er) inherits(er, "oai-pmh_error") ) )
+    expect_true( tryCatch( handle_errors(xml), error=function(er) "noSetHierarchy" %in% attr(er, "error_codes")))
+  }
 
-# })
+})
 
-# rm(tomorrow, error_url, gnp)
+rm(tomorrow, error_url, gnp)